Refactor LongOperationInProgressException #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes LongOperationInProgressException to derive from DeviceCommunicationException. This makes it easier to use the C API as the exception now has a unique numerical identifier. Fixes Nitrokey#170.
|
Looks good! |
szszszsz
approved these changes
Jun 15, 2020
|
That’s an interesting point. I think you said that you want to follow semantic versioning, and that would require a new major release regardless of the Nitrokey App compatibility. Also in the Rust bindings I’m relying on libnitrokey following the semver guidelines. So I would appreciate if you made clear whether you are going to follow the semver guidelines or whether you’ll take a more pragmatic approach. |
sgued
pushed a commit
to sgued/libnitrokey
that referenced
this pull request
Feb 14, 2022
nk3 update: Handle bootloader connection issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes LongOperationInProgressException to derive from
DeviceCommunicationException. This makes it easier to use the C API as
the exception now has a unique numerical identifier.
Fixes #170.