Root pnpm format:check fails on ~134 files across the monorepo — pre-existing quote-style drift ("foo" vs 'foo') and similar formatting inconsistencies.
CI doesn't catch this because:
.github/workflows/ci.yml only runs pnpm lint + pnpm typecheck, never format:check..github/workflows/sdk-typescript-ci.yml runs prettier --check but only on packages/sdk-typescript.
So root pnpm format:check is misleading — it fails locally but everything's green in CI.
Two ways to fix:
A. Conform to prettier across the board. One-shot pnpm format + commit. Big diff, no behavior change. Pairs naturally with #105 (Biome migration) — do it as the first step there so the Biome reformat is the only churn.
B. Narrow the root format:check to what CI enforces. Update scripts.format:check to match the per-package CI step (just sdk-typescript, plus the Python ruff format --check for sdk-python). Stops giving operators a false-fail signal.
Recommend B short-term to unblock #108 (verify script), then A as part of #105.
Root
pnpm format:checkfails on ~134 files across the monorepo — pre-existing quote-style drift ("foo"vs'foo') and similar formatting inconsistencies.CI doesn't catch this because:
.github/workflows/ci.ymlonly runspnpm lint+pnpm typecheck, neverformat:check..github/workflows/sdk-typescript-ci.ymlrunsprettier --checkbut only onpackages/sdk-typescript.So root
pnpm format:checkis misleading — it fails locally but everything's green in CI.Two ways to fix:
A. Conform to prettier across the board. One-shot
pnpm format+ commit. Big diff, no behavior change. Pairs naturally with #105 (Biome migration) — do it as the first step there so the Biome reformat is the only churn.B. Narrow the root
format:checkto what CI enforces. Updatescripts.format:checkto match the per-package CI step (just sdk-typescript, plus the Pythonruff format --checkfor sdk-python). Stops giving operators a false-fail signal.Recommend B short-term to unblock #108 (verify script), then A as part of #105.