Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the division by zero in int/include/nil/blueprint/components/systems/snark/plonk/flexible/colinear_checks.hpp is ok. #388

Open
martun opened this issue May 27, 2024 · 0 comments
Assignees

Comments

@martun
Copy link
Contributor

martun commented May 27, 2024

In int/include/nil/blueprint/components/systems/snark/plonk/flexible/colinear_checks.hpp we are dividing by value of "s", which is sometimes zero. I changed it to

assignment.witness(component.W(block*5 + 8), start_row_index + row) = ((alpha + s ) * y0 - (alpha - s) * y1 ) * (s == 0u ? 0u : (2 * s).inversed()); // new fake y

But I'm not sure if this was a bug, or it's ok that S is sometimes zero. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants