Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating functions with defines. #387

Open
martun opened this issue May 25, 2024 · 0 comments
Open

Stop generating functions with defines. #387

martun opened this issue May 25, 2024 · 0 comments
Assignees

Comments

@martun
Copy link
Contributor

martun commented May 25, 2024

In test/mock/mocked_components.cpp and include/nil/blueprint/components/mock/mocked_components.hpp we are generating classes/functions with defines.

That makes debugging impossible, even compilation errors are hard to find. The compiler does not tell me which line has an error, because the whole generated function is on a single line :)

Consider using simple std::function-s, pass them to some template classes, but do not generate any code with defines.

We should restrict usage of defines to minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants