Testing rig now uses all empty constant columns for lookup table packing.

Author: Iluvmagick

test/test_plonk_component.hpp

@@ -289,14 +289,6 @@ namespace nil {
             }
 
             if constexpr (nil::blueprint::use_lookups<component_type>()) {
-                // Components with lookups may use constant columns.
-                // But now all constants are placed in the first column.
-                // So we reserve the first column for non-lookup constants.
-                // Rather universal for testing
-                // We may start from zero if component doesn't use ordinary constants.
-                std::vector<size_t> lookup_columns_indices;
-                for( std::size_t i = 1; i < ArithmetizationParams::constant_columns; i++ )  lookup_columns_indices.push_back(i);
-
                 std::size_t cur_selector_id = 0;
                 for(const auto &gate: bp.gates()){
                     cur_selector_id = std::max(cur_selector_id, gate.selector_index);
@@ -305,6 +297,13 @@ namespace nil {
                     cur_selector_id = std::max(cur_selector_id, lookup_gate.tag_index);
                 }
                 cur_selector_id++;
+                // Use all of the unused constant columns for lookups
+                std::vector<size_t> lookup_columns_indices;
+                for(std::size_t i = 0; i < ArithmetizationParams::constant_columns; i++) {
+                    if(assignment.constants()[i].size() == 0) {
+                        lookup_columns_indices.push_back(i);
+                    }
+                }
                 desc.usable_rows_amount = zk::snark::pack_lookup_tables_horizontal(
                     bp.get_reserved_indices(),
                     bp.get_reserved_tables(),