From d25abd448fbaec0fa89bd7f742aaa54b1031ff73 Mon Sep 17 00:00:00 2001 From: Andrei Malashkin Date: Fri, 13 Dec 2024 11:19:09 +0100 Subject: [PATCH 1/6] add proof-producer-debug-gcc check in CI --- .../gcc-debug-proof-producer-nix-check.yml | 31 +++++++++++++++++++ .github/workflows/pull-request.yml | 7 +++++ 2 files changed, 38 insertions(+) create mode 100644 .github/workflows/gcc-debug-proof-producer-nix-check.yml diff --git a/.github/workflows/gcc-debug-proof-producer-nix-check.yml b/.github/workflows/gcc-debug-proof-producer-nix-check.yml new file mode 100644 index 0000000000..fc4723613c --- /dev/null +++ b/.github/workflows/gcc-debug-proof-producer-nix-check.yml @@ -0,0 +1,31 @@ +name: Build and Test on Linux Platforms + +on: + workflow_call: + +jobs: + build-and-test: + name: "Build and test Linux with gcc" + runs-on: [self-hosted, Linux, X64, aws_autoscaling] + steps: + # https://github.com/actions/checkout/issues/1552 + - name: Clean up after previous checkout + run: chmod +w -R ${GITHUB_WORKSPACE}; rm -rf ${GITHUB_WORKSPACE}/*; + + - name: Checkout + uses: actions/checkout@v3 + with: + fetch-depth: 0 + + - name: Run checks for debug proof-producer + run: | + nix build -L .?#checks.x86_64-linux.proof-producer-debug-tests + + - name: Publish Test Results + uses: EnricoMi/publish-unit-test-result-action/linux@v2 + with: + check_name: "Proof-producer Debug Test Results" + files: "results/*.xml" + comment_mode: ${{ github.event.pull_request.head.repo.fork && 'off' || 'always' }} # Don't create PR comment from fork runs + action_fail_on_inconclusive: true # fail, if no reports + diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 91ac921fab..35ff987d83 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -30,6 +30,13 @@ jobs: always() && !cancelled() secrets: inherit + test-linux-clang: + name: Linux proof-producer testing with debug gcc + uses: ./.github/workflows/gcc-debug-proof-producer-nix-check.yml + if: | + always() && !cancelled() + secrets: inherit + check-proof-producer: name: Check Proof Producer uses: ./.github/workflows/check-proof-producer.yml From 8b22e851a299a875384f0acc47bdd560d34a730a Mon Sep 17 00:00:00 2001 From: Andrei Malashkin Date: Fri, 13 Dec 2024 11:21:20 +0100 Subject: [PATCH 2/6] hotfix --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 35ff987d83..040df1c6fd 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -30,7 +30,7 @@ jobs: always() && !cancelled() secrets: inherit - test-linux-clang: + test-linux-proof-producer-debug-gcc: name: Linux proof-producer testing with debug gcc uses: ./.github/workflows/gcc-debug-proof-producer-nix-check.yml if: | From d4d551bda1ac0da8f86c96aebf0458068c1815b8 Mon Sep 17 00:00:00 2001 From: Andrei Malashkin Date: Fri, 13 Dec 2024 11:25:39 +0100 Subject: [PATCH 3/6] add more descriptive title to CI jobs --- .github/workflows/gcc-debug-proof-producer-nix-check.yml | 2 +- .github/workflows/pull-request.yml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/gcc-debug-proof-producer-nix-check.yml b/.github/workflows/gcc-debug-proof-producer-nix-check.yml index fc4723613c..e5042ed0c1 100644 --- a/.github/workflows/gcc-debug-proof-producer-nix-check.yml +++ b/.github/workflows/gcc-debug-proof-producer-nix-check.yml @@ -19,7 +19,7 @@ jobs: - name: Run checks for debug proof-producer run: | - nix build -L .?#checks.x86_64-linux.proof-producer-debug-tests + nix build -L .?#checks.x86_64-linux.proof-producer-debug-gcc - name: Publish Test Results uses: EnricoMi/publish-unit-test-result-action/linux@v2 diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 040df1c6fd..b91c9df33d 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -17,21 +17,21 @@ concurrency: jobs: test-linux-gcc: - name: Linux placeholder testing with gcc + name: Gcc release full Linux testing uses: ./.github/workflows/gcc-linux-nix-check.yml if: | always() && !cancelled() secrets: inherit test-linux-clang: - name: Linux placeholder testing with clang + name: Clang release full Linux testing uses: ./.github/workflows/clang-linux-nix-check.yml if: | always() && !cancelled() secrets: inherit test-linux-proof-producer-debug-gcc: - name: Linux proof-producer testing with debug gcc + name: Gcc debug proof-producer Linux testing uses: ./.github/workflows/gcc-debug-proof-producer-nix-check.yml if: | always() && !cancelled() From 67bdb62914cf52af57cd969387d7b571940dcab9 Mon Sep 17 00:00:00 2001 From: Andrei Malashkin Date: Fri, 13 Dec 2024 13:36:42 +0100 Subject: [PATCH 4/6] only build proof-producer executable and not run the tests --- .../workflows/gcc-debug-proof-producer-nix-check.yml | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/gcc-debug-proof-producer-nix-check.yml b/.github/workflows/gcc-debug-proof-producer-nix-check.yml index e5042ed0c1..75335cf4b9 100644 --- a/.github/workflows/gcc-debug-proof-producer-nix-check.yml +++ b/.github/workflows/gcc-debug-proof-producer-nix-check.yml @@ -19,13 +19,5 @@ jobs: - name: Run checks for debug proof-producer run: | - nix build -L .?#checks.x86_64-linux.proof-producer-debug-gcc - - - name: Publish Test Results - uses: EnricoMi/publish-unit-test-result-action/linux@v2 - with: - check_name: "Proof-producer Debug Test Results" - files: "results/*.xml" - comment_mode: ${{ github.event.pull_request.head.repo.fork && 'off' || 'always' }} # Don't create PR comment from fork runs - action_fail_on_inconclusive: true # fail, if no reports - + nix run .#multi-threaded -- --help + nix run .#single-threaded -- --help From f811ac570c18d1dacffdfe4c4f60e407d4f02cd1 Mon Sep 17 00:00:00 2001 From: Andrei Malashkin Date: Mon, 16 Dec 2024 09:34:59 +0100 Subject: [PATCH 5/6] move proof-producer debug build to nightliy --- .github/workflows/nightly.yml | 7 +++++++ .github/workflows/pull-request.yml | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index b7accb798f..eb3e81dec5 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -12,6 +12,13 @@ jobs: always() && !cancelled() secrets: inherit + test-linux-proof-producer-debug-gcc: + name: Gcc debug proof-producer Linux testing + uses: ./.github/workflows/gcc-debug-proof-producer-nix-check.yml + if: | + always() && !cancelled() + secrets: inherit + post-telemetry: name: Post test results in Open Telemetry format runs-on: [self-hosted, Linux, X64, aws_autoscaling] diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index b91c9df33d..38e7f61e4b 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -30,13 +30,6 @@ jobs: always() && !cancelled() secrets: inherit - test-linux-proof-producer-debug-gcc: - name: Gcc debug proof-producer Linux testing - uses: ./.github/workflows/gcc-debug-proof-producer-nix-check.yml - if: | - always() && !cancelled() - secrets: inherit - check-proof-producer: name: Check Proof Producer uses: ./.github/workflows/check-proof-producer.yml From c19767e0b02dff1723b20a06db69f82c815a25cc Mon Sep 17 00:00:00 2001 From: Andrei Malashkin Date: Mon, 16 Dec 2024 11:15:03 +0100 Subject: [PATCH 6/6] correct code review notes --- .github/workflows/gcc-debug-proof-producer-nix-check.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/gcc-debug-proof-producer-nix-check.yml b/.github/workflows/gcc-debug-proof-producer-nix-check.yml index 75335cf4b9..507588d98c 100644 --- a/.github/workflows/gcc-debug-proof-producer-nix-check.yml +++ b/.github/workflows/gcc-debug-proof-producer-nix-check.yml @@ -1,11 +1,11 @@ -name: Build and Test on Linux Platforms +name: Build and run on Linux Platforms on: workflow_call: jobs: - build-and-test: - name: "Build and test Linux with gcc" + build-and-run: + name: "Build proof-producer binary in debug mode" runs-on: [self-hosted, Linux, X64, aws_autoscaling] steps: # https://github.com/actions/checkout/issues/1552 @@ -17,7 +17,7 @@ jobs: with: fetch-depth: 0 - - name: Run checks for debug proof-producer + - name: Build and run proof-producer in debug mode run: | nix run .#multi-threaded -- --help nix run .#single-threaded -- --help