Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

99 bn bbf poseidon #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

99 bn bbf poseidon #113

wants to merge 2 commits into from

Conversation

AntoineCyr
Copy link

No description provided.

@AntoineCyr AntoineCyr linked an issue Oct 24, 2024 that may be closed by this pull request
Posseidon on bn-254 in bbf #99
Open
@AntoineCyr AntoineCyr force-pushed the 99-bn-bbf-poseidon branch 8 times, most recently from f9787ea to 9ea5f9b Compare October 29, 2024 21:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Clang Test Results

  155 files  +  2    155 suites  +2   12m 20s ⏱️ -9s
3 545 tests +  4  3 539 ✅ +  4  6 💤 ±0  0 ❌ ±0 
3 706 runs  +105  3 700 ✅ +105  6 💤 ±0  0 ❌ ±0 

Results for commit edbb863. ± Comparison against base commit 35ea211.

This pull request removes 10 and adds 14 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__keccak_1600<256ul>__nil__crypto3__hashes__keccak_1600<256ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__keccak_1600<512ul>__nil__crypto3__hashes__keccak_1600<512ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__mina_poseidon_policy<nil__crypto3__algebra__fields__pallas_base_field>>__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__mina_poseidon_policy<nil__crypto3__algebra__fields__pallas_base_field>>__false__0ul>>
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__sha2<256ul>__nil__crypto3__hashes__sha2<256ul>__false__0ul>>

blueprint_plonk_poseidon_test_suite ‑ blueprint_plonk_poseidon_test_alt_bn128
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__keccak_1600<256ul>__nil__crypto3__hashes__keccak_1600<256ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__keccak_1600<512ul>__nil__crypto3__hashes__keccak_1600<512ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__poseidon_policy<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__128ul__2ul__void>>__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__poseidon_policy<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__128ul__2ul__void>>__false__0ul>>
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__sha2<256ul>__nil__crypto3__hashes__sha2<256ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test_pallas<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__keccak_1600<256ul>__nil__crypto3__hashes__keccak_1600<256ul>__false__0ul>>
…

♻️ This comment has been updated with latest results.

@AntoineCyr AntoineCyr force-pushed the 99-bn-bbf-poseidon branch 4 times, most recently from fb10b11 to de95214 Compare October 31, 2024 18:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Gcc Test Results

  156 files  +  3    156 suites  +3   36m 1s ⏱️ + 21m 34s
3 548 tests +  7  3 542 ✅ +  7  6 💤 ±0  0 ❌ ±0 
3 709 runs  +108  3 703 ✅ +108  6 💤 ±0  0 ❌ ±0 

Results for commit edbb863. ± Comparison against base commit 35ea211.

This pull request removes 10 and adds 17 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__keccak_1600<256ul>__nil__crypto3__hashes__keccak_1600<256ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__keccak_1600<512ul>__nil__crypto3__hashes__keccak_1600<512ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__mina_poseidon_policy<nil__crypto3__algebra__fields__pallas_base_field>>__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__mina_poseidon_policy<nil__crypto3__algebra__fields__pallas_base_field>>__false__0ul>>
placeholder_hashes_test ‑ hash_test<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__sha2<256ul>__nil__crypto3__hashes__sha2<256ul>__false__0ul>>

blueprint_plonk_poseidon_test_suite ‑ blueprint_plonk_poseidon_test_alt_bn128
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__keccak_1600<256ul>__nil__crypto3__hashes__keccak_1600<256ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__keccak_1600<512ul>__nil__crypto3__hashes__keccak_1600<512ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__poseidon_policy<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__128ul__2ul__void>>__nil__crypto3__hashes__poseidon<nil__crypto3__hashes__detail__poseidon_policy<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__128ul__2ul__void>>__false__0ul>>
placeholder_hashes_test ‑ hash_test_alt_bn<placeholder_test_runner<nil__crypto3__algebra__fields__alt_bn128_scalar_field<254ul>__nil__crypto3__hashes__sha2<256ul>__nil__crypto3__hashes__sha2<256ul>__false__0ul>>
placeholder_hashes_test ‑ hash_test_pallas<placeholder_test_runner<nil__crypto3__algebra__fields__pallas_base_field__nil__crypto3__hashes__keccak_1600<256ul>__nil__crypto3__hashes__keccak_1600<256ul>__false__0ul>>
…

♻️ This comment has been updated with latest results.

@AntoineCyr AntoineCyr marked this pull request as ready for review November 1, 2024 00:00
@AntoineCyr AntoineCyr self-assigned this Nov 1, 2024
@AntoineCyr AntoineCyr requested a review from ETatuzova November 1, 2024 00:00
@AntoineCyr AntoineCyr force-pushed the 99-bn-bbf-poseidon branch 4 times, most recently from 7108bd4 to 9b605e6 Compare November 5, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ETatuzova ETatuzova ETatuzova left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AntoineCyr AntoineCyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Posseidon on bn-254 in bbf
2 participants
@AntoineCyr @ETatuzova