Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to popped stack element #30

Open
CblPOK-git opened this issue Jul 29, 2024 · 0 comments
Open

Reference to popped stack element #30

CblPOK-git opened this issue Jul 29, 2024 · 0 comments
Assignees

Comments

@CblPOK-git
Copy link

CblPOK-git commented Jul 29, 2024

We don't write anything to stack after pop(), so everything works fine, but looks really bad. Maybe better to use
auto& val = stack[i]
instead of
auto& val = stack.pop()
(it will change address_in_stack and rw_circuit tests will start to fail, will need to also update tests)

const auto& x = stack.pop();

@CblPOK-git CblPOK-git self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant