fix: address PR review feedback

- Restore postgres_dba_pgvers_17plus and _13plus version checks
- Revert VACUUM to uppercase (SQL command)
- Revert 'Postgres' terminology (preferred over PostgreSQL)
- Revert DO & UNDO to uppercase (migration operations)

Author: NikolayS

init/generate.sh

@@ -16,6 +16,10 @@ cat > "$WARMUP" <<- VersCheck
   select 1/0;
 \endif
 
+select current_setting('server_version_num')::integer >= 170000 as postgres_dba_pgvers_17plus \gset
+
+select current_setting('server_version_num')::integer >= 130000 as postgres_dba_pgvers_13plus \gset
+
 select current_setting('server_version_num')::integer >= 100000 as postgres_dba_pgvers_10plus \gset
 \if :postgres_dba_pgvers_10plus
   \set postgres_dba_last_wal_receive_lsn pg_last_wal_receive_lsn

sql/i5_indexes_migration.sql

@@ -1,4 +1,4 @@
---Cleanup unused and redundant indexes – do and undo migration DDL
+--Cleanup unused and redundant indexes – DO & UNDO migration DDL
 
 -- Use it to generate a database migration (e.g. RoR's db:migrate or Sqitch)
 -- to drop unused and redundant indexes.

sql/t1_tuning.sql

@@ -1,4 +1,4 @@
---PostgreSQL parameters tuning
+--Postgres parameters tuning
 
 -- For Postgres versions older than 10, copy/paste the part
 -- below the last "\else" (scroll down)

sql/v2_autovacuum_progress_and_queue.sql

@@ -1,4 +1,4 @@
---Vacuum progress and autovacuum queue
+--VACUUM progress and autovacuum queue
 
 -- Based on: https://gitlab.com/snippets/1889668
 

start.psql

@@ -15,17 +15,17 @@
 \echo '  i2 – Redundant indexes'
 \echo '  i3 – Foreign keys with missing or bad indexes'
 \echo '  i4 – Invalid indexes'
-\echo '  i5 – Cleanup unused and redundant indexes – do and undo migration DDL'
+\echo '  i5 – Cleanup unused and redundant indexes – DO & UNDO migration DDL'
 \echo '  l1 – Lock trees (lightweight)'
 \echo '  l2 – Lock trees, detailed (based on pg_blocking_pids())'
 \echo '  p1 – [EXP] Alignment padding: how many bytes can be saved if columns are reordered?'
 \echo '  r1 – Create user with random password (interactive)'
 \echo '  r2 – Alter user with random password (interactive)'
 \echo '  s1 – Slowest queries, by total time (requires pg_stat_statements)'
 \echo '  s2 – Slowest queries report (requires pg_stat_statements)'
-\echo '  t1 – PostgreSQL parameters tuning'
+\echo '  t1 – Postgres parameters tuning'
 \echo '  v1 – Vacuum: current activity'
-\echo '  v2 – Vacuum progress and autovacuum queue'
+\echo '  v2 – VACUUM progress and autovacuum queue'
 \echo '   q – Quit'
 \echo
 \echo Type your choice and press <Enter>:

warmup.psql

@@ -4,6 +4,10 @@
   select 1/0;
 \endif
 
+select current_setting('server_version_num')::integer >= 170000 as postgres_dba_pgvers_17plus \gset
+
+select current_setting('server_version_num')::integer >= 130000 as postgres_dba_pgvers_13plus \gset
+
 select current_setting('server_version_num')::integer >= 100000 as postgres_dba_pgvers_10plus \gset
 \if :postgres_dba_pgvers_10plus
   \set postgres_dba_last_wal_receive_lsn pg_last_wal_receive_lsn