Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't filter empty strings #15

Open
bpappin opened this issue Apr 11, 2017 · 1 comment
Open

don't filter empty strings #15

bpappin opened this issue Apr 11, 2017 · 1 comment

Comments

@bpappin
Copy link

bpappin commented Apr 11, 2017

Got this error exporting strings.

! Found 1 empty value(s) for the following term(s):
! - "empty_blank"

In this case case, I obviously know it's blank, since I named it that way.
Maybe warm the user, but the tool should not arbitrarily filter out empty strings.

@AliSoftware
Copy link
Contributor

Good point. This filter removing empty strings was first added because sometimes POEditor.com returns inconsistent values in the json returned by their API including empty translations for strings that you created and some point and removed later but was still returned by the API…

Maybe it's not worth force-filtering then anymore since we recently migrated to their new v2 API which might not have that problem anymore.

@bpappin care to do a pull request? That shouldn't be much work to remove that existing condition from the existing code 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants