Skip to content

Commit e2a92b6

Browse files
Will McVickerliuyq
Will McVicker
authored andcommitted
ANDROID: drop KERNEL_DIR setting in build.config.common
And replace many references of ${ROOT_DIR}/common with ${ROOT_DIR}/${KERNEL_DIR}, which makes it a lot easier to branch off of ACK and update the KERNEL_DIR. The variable of KERNEL_DIR will be set in build/_setup_env.sh to the directory of the build config file by default if it's not set explicitly in the build config file or in environment. Test: build test with following configs common/build.config.gki.aarch64 common-modules/virtual-device/build.config.cuttlefish.aarch64 common-modules/virtual-device/build.config.goldfish.aarch64 Bug: 162785964 Change-Id: I790ac0ded10bd790484f14c6f93d53e06c38b830 Signed-off-by: Will McVicker <[email protected]> Signed-off-by: Yongqin Liu <[email protected]> (cherry picked from commit 931718fa65fe5e34d143250c048f591a7d74e5f8)
1 parent 0b8c61c commit e2a92b6

11 files changed

+23
-26
lines changed

build.config.allmodconfig.aarch64

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
. ${ROOT_DIR}/common/build.config.common
2-
. ${ROOT_DIR}/common/build.config.aarch64
3-
. ${ROOT_DIR}/common/build.config.allmodconfig
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.common
2+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.aarch64
3+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.allmodconfig
44

build.config.allmodconfig.arm

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
. ${ROOT_DIR}/common/build.config.common
2-
. ${ROOT_DIR}/common/build.config.arm
3-
. ${ROOT_DIR}/common/build.config.allmodconfig
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.common
2+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.arm
3+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.allmodconfig
44

build.config.allmodconfig.x86_64

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
. ${ROOT_DIR}/common/build.config.common
2-
. ${ROOT_DIR}/common/build.config.x86_64
3-
. ${ROOT_DIR}/common/build.config.allmodconfig
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.common
2+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.x86_64
3+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.allmodconfig
44

build.config.common

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
BRANCH=android-4.19-stable
22
KMI_GENERATION=0
3-
KERNEL_DIR=common
43

54
CC=clang
65
LD=ld.lld

build.config.gki-debug.aarch64

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
. ${ROOT_DIR}/common/build.config.gki.aarch64
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.gki.aarch64
22
TRIM_NONLISTED_KMI=""
33
KMI_SYMBOL_LIST_STRICT_MODE=""

build.config.gki-debug.x86_64

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
. ${ROOT_DIR}/common/build.config.gki.x86_64
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.gki.x86_64
22
TRIM_NONLISTED_KMI=""
33
KMI_SYMBOL_LIST_STRICT_MODE=""

build.config.gki.aarch64

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
. ${ROOT_DIR}/common/build.config.common
2-
. ${ROOT_DIR}/common/build.config.aarch64
3-
. ${ROOT_DIR}/common/build.config.gki
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.common
2+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.aarch64
3+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.gki
44

55
ABI_DEFINITION=android/abi_gki_aarch64.xml
66
KMI_SYMBOL_LIST=android/abi_gki_aarch64

build.config.gki.x86_64

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
. ${ROOT_DIR}/common/build.config.common
2-
. ${ROOT_DIR}/common/build.config.x86_64
3-
. ${ROOT_DIR}/common/build.config.gki
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.common
2+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.x86_64
3+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.gki
44

build.config.gki_kasan

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
DEFCONFIG=gki_defconfig
22
POST_DEFCONFIG_CMDS="check_defconfig && update_kasan_config"
3-
KERNEL_DIR=common
43
function update_kasan_config() {
54
${KERNEL_DIR}/scripts/config --file ${OUT_DIR}/.config \
65
-e CONFIG_KASAN \

build.config.gki_kasan.aarch64

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
. ${ROOT_DIR}/common/build.config.common
2-
. ${ROOT_DIR}/common/build.config.aarch64
3-
. ${ROOT_DIR}/common/build.config.gki_kasan
4-
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.common
2+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.aarch64
3+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.gki_kasan

build.config.gki_kasan.x86_64

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
. ${ROOT_DIR}/common/build.config.common
2-
. ${ROOT_DIR}/common/build.config.x86_64
3-
. ${ROOT_DIR}/common/build.config.gki_kasan
1+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.common
2+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.x86_64
3+
. ${ROOT_DIR}/${KERNEL_DIR}/build.config.gki_kasan
44

0 commit comments

Comments
 (0)