Item not visible in inventory while fighting gelatinous cubes

[thisjustin816]

I was poisoned by two gelatinous cubes and went to use a remedy but it wasn't visible. It's still able to be selected though.

Not sure which floor I'm on but I attached a picture of it.

Not sure how to do video on here. Hope this works.

[rsandor]

Oh, that is very strange. Yeah lemme take a look and figure out how to reproduce the issue. The videos work great BTW!

[rsandor]

@thisjustin816 - So to be clear, you could still select the item and use it, but you didn't see the text? Another weird thing is that there are only 3 remedies in the entire game, so if you used one, why do you still have three after?

[grendell]

I'm unfortunately not having any luck reproducing this one leveraging test.c.

gelatinous_remedy.mov

[thisjustin816]

Yeah I used it and it worked. I only noticed because I went to use it the first time and was bummed because I didn't see it and finished without it. Then on the next battle it was there so I used Sameboy rewind to go back and test that it actually worked even though I couldn't see it.

As for still having 3, the only thing I can think of is if items don't reset after dying. At that point I had died a few times I think at varying levels of progress.

[thisjustin816]

I can send you my save state if that's helpful although I've progressed further than that at this point.

[grendell]

Ah, yeah, a death could explain >3 remedies. return_from_death() probably needs a call to clear_inventory(), although that's definitely a call for @rsandor 😁

I noticed that the item's name is a const char *, so in theory something could override the pointer itself. However, modifying this to const char * const doesn't provide any insights.

• Setting name to NULL draws a white box in the item list, so it's not a null pointer.
• Setting the name to an empty string still shows the quantity, so that's not it either.
• Setting the name to a newline still shows the quantity as well!
• Setting the name to 40 spaces (enough to push quantity off the edge of the screen) reproduces the video, but this seems unlikely.

Given all of this, I'm suspecting it's a menu drawing bug, but I don't have any proof... yet. 😄

[rsandor]

@grendell - Oh okay, yeah I forgot I had kept items on death. This was by design. The game gets brutal towards floor 5 so I decided it would ease the burden if players could "stock up" to prepare for it as a strategy.

As far as the bug is concerned, yeah I went through all the code in battle.c related to menu rendering last night and it seems tight from what I can tell. Must be something subtle we're missing.