Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to rewrite In iFrames #55

Open
rxfe-a opened this issue Dec 7, 2023 · 5 comments
Open

Failing to rewrite In iFrames #55

rxfe-a opened this issue Dec 7, 2023 · 5 comments

Comments

@rxfe-a
Copy link

rxfe-a commented Dec 7, 2023

What the issue?

It seems that the Service Worker. Unregisters itself I am using the default SW included in the static files but that's not a problem neccesarilly. Whenever you run or create dynamic in a iframe. It will fail to rewrite the entire HTML page.

Fixes

It seems for me atleast that the NPM package version has fixed alot of issues. But this is a 50/50 chance of working

How to somewhat replicate

just run it in a iFrame. (Both redirecting from a HTML page inside of the iframe and Registering it from the main page work).

Possible Fixes (possibly bad on performance)

  • Make sure that the SW is always being registered correctly somewhat like UV where if its not complete it will register it for you

  • Add A checker that makes sure that the site is completely rewrittern (ik its difficult but its a suggestion)

Conclusion

Just use the NPM package version. and run your proxy and copy your dist files.

Related issues

#65
#14 (Not the issue itself since its fixed but the last comment)

DEMONSTRATION

2023-12-06.22-37-38.mp4
@not-amplify
Copy link

i have this same issue, dynamic doesnt seem to work with the iframe

@not-amplify
Copy link

for example when i try to search something up on google it just creates a new line when i press enter

@rxfe-a
Copy link
Author

rxfe-a commented Jan 17, 2024

it seems its kinda fixed with the node js package?
however its a 50% chance

@not-amplify
Copy link

i got the google page loaded but their builtin search bar doesnt work

@rxfe-a rxfe-a changed the title iFrames break the proxy with links Failing to rewrite In iFrames Feb 2, 2024
@rxfe-a
Copy link
Author

rxfe-a commented Feb 2, 2024

yeah it just fails at rewriting the page

i got the google page loaded but their builtin search bar doesnt work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants