Skip to content

Commit 98facff

Browse files
authored
Merge pull request #42 from Navigraph/build/bundle-axios
2 parents 00cc96f + ae78223 commit 98facff

File tree

5 files changed

+3060
-3220
lines changed

5 files changed

+3060
-3220
lines changed

.changeset/weak-geese-swim.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"@navigraph/app": patch
3+
"@navigraph/auth": patch
4+
"@navigraph/charts": patch
5+
"navigraph": patch
6+
---
7+
8+
Included dependencies like `axios` and `@navigraph/pkce` in the final bundle. Also bumped the target to ES6, which should fix some warnings when using Rollup related to usage of global `this`.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
"jest-environment-jsdom": "^29.2.2",
3434
"prettier": "^2.7.1",
3535
"rimraf": "^3.0.2",
36-
"ts-jest": "^29.0.3",
36+
"ts-jest": "^29.0.5",
3737
"tsup": "^6.3.0",
38-
"turbo": "^1.2.16",
39-
"typescript": "^4.7.4"
38+
"turbo": "^1.8.5",
39+
"typescript": "^5.0.2"
4040
}
4141
}

packages/auth/package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,10 @@
3939
"postpack": "clean-package restore"
4040
},
4141
"dependencies": {
42-
"@navigraph/pkce": "^1.0.3",
43-
"@navigraph/app": "1.3.0",
44-
"axios": "^0.24.0"
42+
"@navigraph/app": "1.3.0"
4543
},
4644
"devDependencies": {
47-
"@types/qr-image": "^3.2.5"
45+
"@navigraph/pkce": "^1.0.3",
46+
"axios": "^0.24.0"
4847
}
4948
}

tsup.config.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ import { defineConfig } from "tsup";
33
export default defineConfig({
44
clean: true,
55
format: ["cjs", "esm"],
6-
target: "es5",
7-
outExtension(ctx) {
8-
return { js: `.${ctx.format}.js` };
9-
},
6+
target: "es6",
7+
noExternal: ["axios", "@navigraph/pkce"],
8+
outExtension: (ctx) => ({ js: `.${ctx.format}.js` }),
109
});

0 commit comments

Comments
 (0)