[@nativescript/facebook] androidx.fragment 1.3.0+ breaks navigation in nested frames

[delaneyb]

Wasn't sure if this issue was better suited for here or NativeScript/NativeScript:

• A vanilla 8.1.5 / 8.1.1 project created with ns create from the main repo defines androidx.fragment version 1.2.5 to be used via build.gradle. Navigation in nested frames works just fine.
• @nativescript/facebook's gradle file adds a dependency on facebook-login, which in turn depends on facebook-common
• facebook-common, from version 12 now depends on androidx.fragment 1.3.0
• This dependency overrides the default 1.2.5, which breaks navigation in nested frames. My observation was that transitionOrAnimationCompleted (core/ui/frame/fragment.transitions.android.ts#L653) was never getting called for the nested frame when its initial content was loaded when androidx.fragment 1.3.0 was used, leading to _executingContext never being set to null so then processNextNavigationEntry would return early and not perform the actual navigation when called next time.

Minimal repro - app with nested frame on which navigation does nothing due to override of androidx.fragment version to 1.3.0 via App_Resources/Android/app.gradle: https://github.com/delaneyb/androidx-fragment-130-repro

As a temporary workaround the com.facebook.android:facebook-login version can be downgraded to 11.3.0

Related:
EddyVerbruggen/nativescript-plugin-firebase#1868

[edusperoni]

Hey! I ran into this recently and pushed a fix:

NativeScript/NativeScript#9725

Try running with the alpha tag in NativeScript and see if that helps

[delaneyb]

Hey! I ran into this recently and pushed a fix:

NativeScript/NativeScript#9725

Try running with the alpha tag in NativeScript and see if that helps

Aweeesomee, must have just missed that one! Navigation on a nested frame in the little repro I threw together runs fine with both androidx.fragment 1.3.0 and 1.4.0 with your changes. Need to migrate our main project to NS8 after which I can do some more thorough testing. I'll keep an eye on NativeScript/NativeScript#9728. Thanks Eduardo!