Skip to content

ValueError in battery sizing functions causes errors for batch jobs #134

@brtietz

Description

@brtietz

The dGen team reported that they were commenting out the following lines in their local PySAM implementations in order to make their code run successfully: https://github.com/NREL/pysam/blob/a7dc841caa011dbccd0f998e390ec865b556cb2a/files/BatteryTools.py#L306

While that line makes sense for a single resizing, we should consider the implications for batch jobs. Decide whether to:

  1. Maintain the error as is, but add try-except to our examples (with recommendations of how to handle the except_
  2. Increase the tolerance
  3. Provide a user-specified tolerance or allow users to turn the error off in the function call.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions