3.11.0 Testing

[DavidGoldwasser]

Running measure tests manually on Mac with most recent PR. Soon should be running on CI.
http://openstudio-ci-builds.s3-website-us-west-2.amazonaws.com/?prefix=PR-5532/

Measures listed directly below had all passing tests, measures with errors or failures will be listed as separate comments

• create_bar_from_doe_building_type_ratios_test.rb (50 runs, 316 assertions, 0 failures, 0 errors, 6 skips)
• create_bar_from_building_type_ratios (80 runs, 516 assertions, 0 failures, 0 errors, 10 skips)
• create_bar_from_deer_building_type_ratios (1 runs, 4 assertions, 0 failures, 0 errors, 0 skips)
• create_bar_from_model (9 runs, 36 assertions, 0 failures, 0 errors, 0 skips)
• create_bar_from_space_type_ratios (7 runs, 21 assertions, 0 failures, 0 errors, 4 skips)
• create_typical_deer_building_from_model (1 runs, 4 assertions, 0 failures, 0 errors, 0 skips)

[DavidGoldwasser]

create_typical_doe_building_from_model: 1 test error

CreateTypicalDOEBuildingFromModel_Test#test_generic_gbxml:
NameError: undefined local variable or method zone' for OpenstudioStandards::ThermalZone:Module :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/thermal_zone/thermostat_schedules.rb:110:in block in thermal_zones_set_thermostat_schedules'
:/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/thermal_zone/thermostat_schedules.rb:17:in each' :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/thermal_zone/thermostat_schedules.rb:17:in thermal_zones_set_thermostat_schedules'
:/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/create_typical/create_typical.rb:586:in create_typical_building_from_model' /Users/dgoldwas/Documents/github/nrel/openstudio-model-articulation-gem/lib/measures/create_typical_doe_building_from_model/measure.rb:481:in run'
/Users/dgoldwas/Documents/github/nrel/openstudio-model-articulation-gem/lib/measures/create_typical_doe_building_from_model/tests/create_typical_doe_building_from_model_test.rb:77:in apply_measure_to_model' /Users/dgoldwas/Documents/github/nrel/openstudio-model-articulation-gem/lib/measures/create_typical_doe_building_from_model/tests/create_typical_doe_building_from_model_test.rb:155:in test_generic_gbxml'

7 runs, 22 assertions, 0 failures, 1 errors, 0 skips

[DavidGoldwasser]

create_typical_building_from_model: 1 test error

CreateTypicalBuildingFromModel_Test#test_generic_gbxml:
NameError: undefined local variable or method zone' for OpenstudioStandards::ThermalZone:Module :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/thermal_zone/thermostat_schedules.rb:110:in block in thermal_zones_set_thermostat_schedules'
:/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/thermal_zone/thermostat_schedules.rb:17:in each' :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/thermal_zone/thermostat_schedules.rb:17:in thermal_zones_set_thermostat_schedules'
:/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/create_typical/create_typical.rb:586:in create_typical_building_from_model' /Users/dgoldwas/Documents/github/nrel/openstudio-model-articulation-gem/lib/measures/create_typical_building_from_model/measure.rb:478:in run'
/Users/dgoldwas/Documents/github/nrel/openstudio-model-articulation-gem/lib/measures/create_typical_building_from_model/tests/create_typical_building_from_model_test.rb:74:in apply_measure_to_model' /Users/dgoldwas/Documents/github/nrel/openstudio-model-articulation-gem/lib/measures/create_typical_building_from_model/tests/create_typical_building_from_model_test.rb:152:in test_generic_gbxml'

61 runs, 282 assertions, 0 failures, 1 errors, 1 skips

[DavidGoldwasser]

Testing with RC1 on Arm mac. Happens on create_typical, create_bar, create_prototype, and create_baseline measures.

`(base) dgoldwas:0:measures$ openstudio create_typical_building_from_model/tests/create_typical_building_from_model_test.rb
[ShowRunnerOutput.rb] <0> Deprecated at 3.11.0, use WorkflowStepResult::showOutput() instead

SyntaxError: :/ruby/3.2.0/gems/openstudio-standards-0.8.4/lib/openstudio-standards/btap/costing/daylighting_sensor_control_costing.rb:8: invalid character property name {L}: /(?<=\p{L})(?=\d)/`

Here is line 8 in full
standards_template = standards_template.gsub(/(?<=\p{L})(?=\d)/, ' ') #insert a space between NECB and 2011/2015/2017

I'm a little confused while openstudio create_bar_from_building_type_ratios/tests/create_bar_from_building_type_ratios_test.rb

when I install the gem un-altered in my system ruby and run ruby create_bar_from_building_type_ratios/tests/create_bar_from_building_type_ratios_test.rb

I need to investigate why the behavior is different in standards gem packaged in OpenStudio. Most likely maybe that is older version?

When I type openstudio gem_list I get openstudio-standards (0.8.4) ':/ruby/3.2.0/gems/openstudio-standards-0.8.4'

[DavidGoldwasser]

Using system Ruby with 3.11 rc1 create_bar_from_building_type_ratio and create_typical_building_from_model seem to work fine. I'm testing other variations of that now and will test baseline and prototype.

[DavidGoldwasser]

• Replace temp fix to github action that lets me get to dashboard in CI form now but shows pass when even when some measures fail. openstudio --verbose measure -r ./lib/measures || true
  https://github.com/NREL/openstudio-model-articulation-gem/blob/os_0311_prep/.github/workflows/test-with-openstudio.yml#L74C9-L74C65

• Updating Alliance and copyright year after merge in all other active PR's to this.

• All tests past on CI

• Address extra failure on Mac Arm that isn't on CI

[DavidGoldwasser]

rc2 CI

• RadiantSlabWithDOAS (4 test errors - expect fix is update to measure)
  Failure: test_single_zone_office_5A_floor(Minitest::Result) [/__w/openstudio-model-articulation-gem/openstudio-model-articulation-gem/lib/measures/radiant_slab_with_doas/measure.rb:188]: NoMethodError: undefined method remove_hvac' f`

On Mac Arm local run one, more failure that didn't show on on CI for one of the 43 tests for Create_BarFromDEOBuildingTypeRatios.
Failure: test_multi_rot_a(Minitest::Result) [/Users/dgoldwas/Documents/github/nrel/openstudio-model-articulation-gem/lib/measures/create_bar_from_doe_building_type_ratios/tests/create_bar_from_doe_building_type_ratios_test.rb:60]: Expected: "Success" Actual: "Fail"