Skip to content

Commit 980f263

Browse files
committed
Manual fix for Style/OptionalBooleanParameter
``` test_helpers.rb:512:55: E: Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use compare_eui: true instead of compare_eui = true. def postprocess_out_osw_and_copy(out_osw, cp_out_osw, compare_eui = true) ^^^^^^^^^^^^^^^^^^ ```
1 parent efa3472 commit 980f263

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

test_helpers.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ def compare_osw_eui_with_previous_version(cp_out_osw, eui_pct_threshold: $EuiPct
509509
#
510510
# @return result_osw [Hash]: the sanitized result_osw should you need to do
511511
# more stuff with it
512-
def postprocess_out_osw_and_copy(out_osw, cp_out_osw, compare_eui = true)
512+
def postprocess_out_osw_and_copy(out_osw, cp_out_osw, compare_eui: true)
513513
raise "Cannot find file #{out_osw}" if !File.exist?(out_osw)
514514

515515
result_osw = nil
@@ -797,7 +797,7 @@ def sim_test(filename, options = {})
797797
end
798798

799799
# Post-process the out_osw
800-
result_osw = postprocess_out_osw_and_copy(out_osw, cp_out_osw, compare_eui)
800+
result_osw = postprocess_out_osw_and_copy(out_osw, cp_out_osw, compare_eui: compare_eui)
801801

802802
# return result_osw for further checks
803803
return result_osw
@@ -884,7 +884,7 @@ def autosizing_test(filename, weather_file = nil, model_measures = [], energyplu
884884

885885
# false to skip the call to compare_osw_eui_with_previous_version
886886
# this is an ever changing test, so EUI comparison is boggus
887-
result_osw = postprocess_out_osw_and_copy(out_osw, cp_out_osw, false)
887+
result_osw = postprocess_out_osw_and_copy(out_osw, cp_out_osw, compare_eui: false)
888888

889889
# Load the model
890890
versionTranslator = OpenStudio::OSVersion::VersionTranslator.new

0 commit comments

Comments
 (0)