Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDR has extraneous "suggest" route #357

Closed
spilth opened this issue Aug 8, 2024 · 1 comment
Closed

SDR has extraneous "suggest" route #357

spilth opened this issue Aug 8, 2024 · 1 comment
Assignees

Comments

@spilth
Copy link
Collaborator

spilth commented Aug 8, 2024

The routes file has a resources route for suggest but:

  • There's only 1 request to this URL in production in the last week and I’m pretty sure that was me testing it
  • It doesn’t seem to be used anywhere in the codebase
    • Note that Solr’s /suggest is something different
  • It maps to a Rails controller that does not exist
  • It currently returns {"status":404,"error":"Not Found"}
  • The test suite still passes when this route is removed

I suspect this was some pre GBL 4 route that can be safely removed.

@spilth
Copy link
Collaborator Author

spilth commented Aug 8, 2024

Fixed by #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant