Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includes warping that works in 2d setting #134

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

svsambandam
Copy link

No description provided.

@svsambandam
Copy link
Author

yay! it also includes hashnerf-pytorch :)

@orperel
Copy link
Collaborator

orperel commented Mar 23, 2023

Hi @svsambandam , thanks a lot for sharing this one! :)
Is this still work in progress?

From quickly browsing through we would need:

  1. To clean up some of the redundant code (i.e. _raymarch_2d, debug prints, etc)
  2. A little example of how to run + expected output

@svsambandam
Copy link
Author

svsambandam commented Mar 23, 2023 via email

@orperel
Copy link
Collaborator

orperel commented Mar 23, 2023

No worries! We're squashing everything before we merge it anyway. Feel free to post as many commits needed, just let me know when this is ready to review & push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants