Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] RapidsConf configs with value checks only check value on startup #31

Open
revans2 opened this issue May 28, 2020 · 0 comments
Open

[BUG] RapidsConf configs with value checks only check value on startup #31

revans2 opened this issue May 28, 2020 · 0 comments
Labels
bug Something isn't working P2 Not required for release

Comments

@revans2
Copy link
Collaborator

revans2 commented May 28, 2020

Describe the bug
I noticed that the value checks only occur if the config was set during startup (e.g.: via --conf on the command-line). The check will not occur if the config is later set, e.g.: spark.conf.set(...)

To fix this, I think we need to register our new configs with Spark's SQLConf, which means we probably need to use their ConfigBuilder rather than our own.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 28, 2020
@sameerz sameerz added P2 Not required for release and removed ? - Needs Triage Need team to review and classify labels Aug 18, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 2c6b0da (NVIDIA#31)
8640596 
Signed-off-by: spark-rapids automation <[email protected]>
nvliyuan referenced this issue in nvliyuan/yuali-spark-rapids Feb 29, 2024
@firestarman
one more metrics for expand (#31)
429b354 
Signed-off-by: Firestarman <[email protected]>
liurenjie1024 pushed a commit to liurenjie1024/spark-rapids that referenced this issue Jun 27, 2024
@res-life
Case when perf (NVIDIA#31)
a17837b 
* case when improvement: avoid copy_if_else

Signed-off-by: Chong Gao <[email protected]>

* � This is the 1st commit message:

case when improvement: avoid copy_if_else

Signed-off-by: Chong Gao <[email protected]>

� This is the commit message NVIDIA#2:

Add test case

Add test case

Fix code format

Use Table.gather instead of a custom kernel

Signed-off-by: Chong Gao <[email protected]>

---------

Signed-off-by: Chong Gao <[email protected]>
Co-authored-by: Chong Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P2 Not required for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@revans2 @sameerz