Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛[BUG]: Older torch versions do not support the latest distributed tools #815

Closed
NickGeneva opened this issue Mar 19, 2025 · 0 comments · Fixed by #820
Closed

🐛[BUG]: Older torch versions do not support the latest distributed tools #815

NickGeneva opened this issue Mar 19, 2025 · 0 comments · Fixed by #820
Assignees
@coreyjadams @ktangsali
Labels
bug Something isn't working

Comments

@NickGeneva
Copy link
Collaborator

NickGeneva commented Mar 19, 2025 •
edited
Loading

Version

1.0.0

On which installation method(s) does this occur?

Pip

Describe the issue

physicsnemo/pyproject.toml

Line 23 in 4348562

"torch>=2.0.0",

Needs a bump to likely 2.5.0.

Minimum reproducible example

from physicsnemo.distributed.manager import DistributedManager

Relevant log output

 from physicsnemo.distributed.manager import DistributedManager
/usr/local/lib/python3.10/dist-packages/physicsnemo/__init__.py:19: in <module>
    from .models.meta import ModelMetaData
/usr/local/lib/python3.10/dist-packages/physicsnemo/models/__init__.py:17: in <module>
    from .module import Module
/usr/local/lib/python3.10/dist-packages/physicsnemo/models/module.py:33: in <module>
    from physicsnemo.utils.filesystem import _download_cached, _get_fs
/usr/local/lib/python3.10/dist-packages/physicsnemo/utils/__init__.py:17: in <module>
    from .capture import (
/usr/local/lib/python3.10/dist-packages/physicsnemo/utils/capture.py:28: in <module>
    from physicsnemo.distributed import DistributedManager
/usr/local/lib/python3.10/dist-packages/physicsnemo/distributed/__init__.py:18: in <module>
    from ._shard_tensor_spec import ShardTensorSpec
/usr/local/lib/python3.10/dist-packages/physicsnemo/distributed/_shard_tensor_spec.py:23: in <module>
    from torch.distributed.tensor._dtensor_spec import (
E   ModuleNotFoundError: No module named 'torch.distributed.tensor._dtensor_spec'

Environment details


      		
    

      
  





        

            


            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @NickGeneva
NickGeneva




            added
      

  ? - Needs Triage

  Need team to review and classify

      

  bug

  Something isn't working

  labels


      Mar 19, 2025

    

  



    


    

    

      
    

    


      

          @NickGeneva
NickGeneva




          removed
  the 

  ? - Needs Triage

  Need team to review and classify
 label


      Mar 19, 2025

    

  



  

  

    
  


  

      

    @coreyjadams
coreyjadams



    mentioned this issue
    
      Mar 20, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    5 tasks
  





  




    

    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @coreyjadams
  
    coreyjadams
    

      

      

        

  
      @ktangsali
  
    ktangsali
    

      








      


  


  

    Labels
  



    

      

    bug

  Something isn't working








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      Address pytorch versioning issues.

    
      coreyjadams/physicsnemo
    





      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @NickGeneva 
        
          @coreyjadams 
        
          @ktangsali