egl-wayland: Initialize streamImages during Pbuffer surface creation

We are missing the initializer for the streamImages wl_list in
wlEglCreatePbufferSurfaceHook. This ensures the list is valid when we
eventually destroy the surface and have to check the list contents.

This change adds a common initialization function
wlEglInitializeSurfaceCommon which is used by both surface creators
to set up common state such as these wl_lists.

This fixes crashes with qt6webengine.

Author: amshafer

src/wayland-eglsurface.c

@@ -2609,6 +2609,22 @@ getWlEglWindowVersionAndSurface(struct wl_egl_window *window,
     }
 }
 
+static bool
+wlEglInitializeSurfaceCommon(WlEglDisplay *display,
+                             WlEglSurface *surface,
+                             EGLConfig config)
+{
+    surface->wlEglDpy = display;
+    surface->eglConfig = config;
+    surface->syncPoint = 1;
+    surface->refCount = 1;
+    surface->isDestroyed = EGL_FALSE;
+    wl_list_init(&surface->ctx.streamImages);
+    wl_list_init(&surface->oldCtxList);
+
+    return wlEglInitializeMutex(&surface->ctx.streamImagesMutex);
+}
+
 EGLSurface wlEglCreatePlatformWindowSurfaceHook(EGLDisplay dpy,
                                                 EGLConfig config,
                                                 void *nativeWin,
@@ -2669,17 +2685,17 @@ EGLSurface wlEglCreatePlatformWindowSurfaceHook(EGLDisplay dpy,
         goto fail;
     }
 
-    if (!wlEglInitializeMutex(&surface->mutexLock)) {
+    if (!wlEglInitializeSurfaceCommon(display, surface, config)) {
         err = EGL_BAD_ALLOC;
         goto fail;
     }
 
-    if (!wlEglInitializeMutex(&surface->mutexFrameSync)) {
+    if (!wlEglInitializeMutex(&surface->mutexLock)) {
         err = EGL_BAD_ALLOC;
         goto fail;
     }
 
-    if (!wlEglInitializeMutex(&surface->ctx.streamImagesMutex)) {
+    if (!wlEglInitializeMutex(&surface->mutexFrameSync)) {
         err = EGL_BAD_ALLOC;
         goto fail;
     }
@@ -2689,18 +2705,11 @@ EGLSurface wlEglCreatePlatformWindowSurfaceHook(EGLDisplay dpy,
         goto fail;
     }
 
-    wl_list_init(&surface->ctx.streamImages);
-
-    surface->wlEglDpy = display;
-    surface->eglConfig = config;
     surface->wlEglWin = window;
     surface->ctx.eglStream = EGL_NO_STREAM_KHR;
     surface->ctx.eglSurface = EGL_NO_SURFACE;
     surface->ctx.isOffscreen = EGL_FALSE;
     surface->isSurfaceProducer = EGL_TRUE;
-    surface->refCount = 1;
-    surface->isDestroyed = EGL_FALSE;
-    surface->syncPoint = 1;
     // FIFO_LENGTH == 1 to set FIFO mode, FIFO_LENGTH == 0 to set MAILBOX mode
     // We set two here however to bump the "swapchain" count to 4 on Wayland.
     // This is done to better match what Mesa does, as apparently 4 is the
@@ -2732,7 +2741,6 @@ EGLSurface wlEglCreatePlatformWindowSurfaceHook(EGLDisplay dpy,
     getWlEglWindowVersionAndSurface(window,
                                     &surface->wlEglWinVer,
                                     &surface->wlSurface);
-    wl_list_init(&surface->oldCtxList);
 
     err = assignWlEglSurfaceAttribs(surface, attribs);
     if (err != EGL_SUCCESS) {
@@ -2883,18 +2891,13 @@ EGLSurface wlEglCreatePbufferSurfaceHook(EGLDisplay dpy,
         goto fail;
     }
 
-    if (!wlEglInitializeMutex(&surface->mutexLock)) {
+    if (!wlEglInitializeSurfaceCommon(display, surface, config)) {
         err = EGL_BAD_ALLOC;
         goto fail;
     }
 
-    surface->wlEglDpy = display;
-    surface->eglConfig = config;
     surface->ctx.eglSurface = surf;
     surface->ctx.isOffscreen = EGL_TRUE;
-    surface->refCount = 1;
-    surface->isDestroyed = EGL_FALSE;
-    wl_list_init(&surface->oldCtxList);
 
     wl_list_insert(&display->wlEglSurfaceList, &surface->link);
     pthread_mutex_unlock(&display->mutex);