Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Tuning policy will not be selected properly for CUB Merge Sort #3895

Open
1 task done
NaderAlAwar opened this issue Feb 21, 2025 · 0 comments · May be fixed by #3897
Open
1 task done

[BUG]: Tuning policy will not be selected properly for CUB Merge Sort #3895

NaderAlAwar opened this issue Feb 21, 2025 · 0 comments · May be fixed by #3897
Assignees
Labels
bug Something isn't working right.

Comments

@NaderAlAwar
Copy link
Contributor

Is this a duplicate?

Type of Bug

Something else

Component

CUB

Describe the bug

The dynamic dispatch PR for Merge Sort #3525 introduced a bug into how the tuning policy is selected. By making VSMemHelper a template of the DispatchMergeSort class that is instantiated with typename PolicyHub::MaxPolicy::MergeSortPolicy, this PR changed the original behavior, where we were instantiating it with the ActivePolicy passed from Invoke(), which would have selected the correct tuning policy. See this comment as well #3525 (comment).

How to Reproduce

There are differences in the SASS for pre-Pascal architectures before and after applying the changes in this PR.

Expected behavior

VSMemHelper should be instantiated with the correct policy.

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

@NaderAlAwar NaderAlAwar added the bug Something isn't working right. label Feb 21, 2025
@NaderAlAwar NaderAlAwar self-assigned this Feb 21, 2025
@github-project-automation github-project-automation bot moved this to Todo in CCCL Feb 21, 2025
@NaderAlAwar NaderAlAwar linked a pull request Feb 21, 2025 that will close this issue
2 tasks
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Feb 21, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

1 participant