Repository navigation
Conversation
Signed-off-by: Taian Zhang <taianz@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe integration test waiver list no longer skips the Cosmos3 offload baseline comparison test. The entry’s NVBUG 6702264 reference was also removed. ChangesCosmos3 Offload Test Waiver
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title follows the required NVBugs and type format. It clearly states that the Cosmos3 offload test waiver was removed. |
| Description check | |
The description clearly explains the change, its purpose, and the reported test coverage. It does not include the full PR checklist, but the missing checklist is non-critical for this change. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
/bot run --extra-stage "DGX_B200-PyTorch-Post-Merge-1" |
|
PR_Github #77797 [ run ] triggered by Bot. Commit: |
|
PR_Github #77797 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_B200-PyTorch-Post-Merge-1" |
|
PR_Github #77947 [ run ] triggered by Bot. Commit: |
|
PR_Github #77947 [ run ] completed with state
|
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
taianz-nv
changed the title
|
/bot run --extra-stage "DGX_B200-PyTorch-Post-Merge-1" |
|
PR_Github #78954 [ run ] triggered by Bot. Commit: |
|
PR_Github #78954 [ run ] completed with state
|
This branch has not been deployed
4 participants
Summary
Testing
pre-commit run --files tests/integration/test_lists/waives.txtpython scripts/test_to_stage_mapping.py --tests "unittest/_torch/visual_gen/test_cosmos3_t2v_offload.py::TestCosmos3Offload::test_cosmos3_offload_matches_baseline"The stage mapping resolves to both
DGX_B200-PyTorch-Post-Merge-1andDGX_B200-PyTorch-Post-Merge-2; the GPU validation will be triggered on this PR.Dev Engineer Review
The change removes the NVBUG 6702264 waiver for the Cosmos3 offload correctness test. This restores the test to normal CI execution without changing test code or runtime behavior.
QA Engineer Review
The waiver entry was removed from
tests/integration/test_lists/waives.txt. The test remains listed intests/integration/test_lists/test-db/l0_b200.yml, so CI coverage is configured for B200. The test compares Cosmos3 offload output with the baseline. GPU validation is reported as planned; no result was supplied. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Removing the waiver allows the existing offload correctness test to run. The test is listed in the B200 CI test list.