Repository navigation
[None][infra] Upgrade NIXL to v1.5.0 and UCX to v1.23.x - #20099
Conversation
|
/bot run --stage-list "Build-Docker-Images" |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe NIXL installer and development requirements now use version 1.5.0. The UCX installer pin changes to v1.23.x and its associated commit. Five Jenkins image variables now reference staging Triton-devel images tagged for PR 20099. ChangesDependency version updates
Jenkins image tags
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description retains the template and marks the checklist complete, but it provides no issue explanation, implementation details, test coverage, or test results. The objectives also report failed m… | Add a concise Description section that explains the upgrade and its purpose. Add a Test Coverage section listing the executed Docker image builds and multi-GPU tests, including results. Document the failed pipeline status and any remediatio… |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly identifies the infrastructure changes: upgrading NIXL to v1.5.0 and UCX to v1.23.x. It follows the required [None][type] format. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Description check
-
Explanation
The description retains the template and marks the checklist complete, but it provides no issue explanation, implementation details, test coverage, or test results. The objectives also report failed merge-request pipelines without identifying the failures.
Resolution
Add a concise Description section that explains the upgrade and its purpose. Add a Test Coverage section listing the executed Docker image builds and multi-GPU tests, including results. Document the failed pipeline status and any remediation or follow-up validation.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
PR_Github #77140 [ run ] triggered by Bot. Commit: |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #77145 [ run ] triggered by Bot. Commit: |
|
PR_Github #77140 [ run ] completed with state |
|
PR_Github #77145 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #77159 [ run ] triggered by Bot. Commit: |
|
PR_Github #77159 [ run ] completed with state
|
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #77234 [ run ] triggered by Bot. Commit: |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #77263 [ run ] triggered by Bot. Commit: |
|
PR_Github #77234 [ run ] completed with state |
|
PR_Github #77263 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #77460 [ run ] triggered by Bot. Commit: |
|
PR_Github #77460 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #77531 [ run ] triggered by Bot. Commit: |
|
PR_Github #77531 [ run ] completed with state
|
25df2cb to
3e8b46c
Compare
|
PR_Github #78128 [ run ] completed with state
|
Signed-off-by: Yoray Zack <yorayz@nvidia.com>
915d8b6 to
a8712f4
Compare
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #78697 [ run ] triggered by Bot. Commit: |
Signed-off-by: Yoray Zack <yorayz@nvidia.com>
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #78701 [ run ] triggered by Bot. Commit: |
|
PR_Github #78697 [ run ] completed with state |
|
PR_Github #78701 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #78727 [ run ] triggered by Bot. Commit: |
|
PR_Github #78727 [ run ] completed with state
|
Signed-off-by: Yoray Zack <yorayz@nvidia.com>
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #78866 [ run ] triggered by Bot. Commit: |
|
PR_Github #78866 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #79208 [ run ] triggered by Bot. Commit: |
|
PR_Github #79208 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #79255 [ run ] triggered by Bot. Commit: |
|
PR_Github #79255 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #79528 [ run ] triggered by Bot. Commit: |
|
PR_Github #79528 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #79672 [ run ] triggered by Bot. Commit: |
|
PR_Github #79672 [ run ] completed with state |
5 participants
Dev Engineer Review
NIXL source and development package pins now use version 1.5.0. The UCX installer now uses v1.23.x at commit
65e342a82dd2609a28c8c2b8c45ed7fe2cb33fa0. Five image tags also changed to staging Triton-devel images. Verify that the dependency versions build together and that the images match the intended targets.PR_Github runs 77145 and 77159 completed, but their associated L0_MergeRequest_PR pipelines failed. The available reports do not identify the failed tests. The result of Docker image build run 77234 was not reported.
QA Engineer Review
No test changes.
Per-File QA Perspective
docker/common/install_nixl.sh: The installer now builds NIXL v1.5.0. Verify the build with the configured UCX and CUDA paths.docker/common/install_ucx.sh: The installer now fetches the pinned UCX v1.23.x commit. Verify the build and installation in the supported build environment.requirements-dev.txt: Thenixl-cu13pin now uses version 1.5.0. Verify that development environments resolve and install the package.jenkins/current_image_tags.properties: Five image references now use staging Triton-devel images. Verify that the image variants match the intended architecture and operating-system targets.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.