refactor(server): extract kubernetes compute driver#817
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
mrunalp
reviewed
Apr 13, 2026
mrunalp
reviewed
Apr 13, 2026
proto/compute_driver.proto
Outdated
| rpc CreateSandbox(ComputeCreateSandboxRequest) returns (ComputeCreateSandboxResponse); | ||
|
|
||
| // Tear down platform resources for a sandbox. | ||
| rpc DeleteSandbox(ComputeDeleteSandboxRequest) returns (ComputeDeleteSandboxResponse); |
There was a problem hiding this comment.
Should there be a separate StopSandbox so there is an opportunity to inspect state before calling DeleteSandbox?
Collaborator
Author
There was a problem hiding this comment.
Good call. We probably also want to be able to resume the sandbox. Being able to clone or copy may also be useful down the road.
Collaborator
Author
There was a problem hiding this comment.
On second thought, don't need explicit resume. We can auto resume on connect or exec.
mrunalp
reviewed
Apr 13, 2026
mrunalp
reviewed
Apr 13, 2026
proto/sandbox.proto
Outdated
| string namespace = 3; | ||
| SandboxSpec spec = 4; | ||
| SandboxStatus status = 5; | ||
| SandboxPhase phase = 6; |
mrunalp
reviewed
Apr 13, 2026
mrunalp
reviewed
Apr 13, 2026
mrunalp
reviewed
Apr 13, 2026
|
Thanks for the changes. lgtm! |
maxamillion
reviewed
Apr 14, 2026
maxamillion
left a comment
maxamillion
left a comment
There was a problem hiding this comment.
LGTM - I think there's room to iterate on a couple small things later but this is really good 👍
johntmyers
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the Kubernetes sandbox implementation out of
openshell-serverinto a dedicated compute-driver crate and introduce shared sandbox protobufs for gateway and driver internals.Closes OS-51
Changes
proto/sandbox.protoand added internal compute driver RPCs inproto/compute_driver.protoopenshell-driver-kubernetescrate with the extracted Kubernetes driver library and tonic service binaryopenshell-serverwith a gateway-owned compute runtime and routed sandbox creation, deletion, watch handling, and endpoint resolution through itTesting
mise run pre-commitpassesAdditional verification:
cargo test -p openshell-driver-kubernetes --libcargo test -p openshell-server --libChecklist