Skip to content

Commit 191f72d

Browse files
committed
fix(docker): enable dev-settings feature by default in local builds
Local image builds via mise run cluster / mise run docker:build:* were missing the dev-settings feature flag, causing e2e tests to fail with 'unknown setting key dummy_bool'. CI sets EXTRA_CARGO_FEATURES explicitly but the local path did not. Default EXTRA_CARGO_FEATURES to openshell-core/dev-settings so local builds match CI. The variable can still be overridden by the caller.
1 parent bbcaed2 commit 191f72d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tasks/scripts/docker-build-image.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,12 @@ else
159159
exit 1
160160
fi
161161

162+
# Default to dev-settings so local builds include test-only settings
163+
# (dummy_bool, dummy_int) that e2e tests depend on, matching CI behaviour.
164+
EXTRA_CARGO_FEATURES="${EXTRA_CARGO_FEATURES:-openshell-core/dev-settings}"
165+
162166
FEATURE_ARGS=()
163-
if [[ -n "${EXTRA_CARGO_FEATURES:-}" ]]; then
167+
if [[ -n "${EXTRA_CARGO_FEATURES}" ]]; then
164168
FEATURE_ARGS=(--build-arg "EXTRA_CARGO_FEATURES=${EXTRA_CARGO_FEATURES}")
165169
fi
166170

0 commit comments

Comments
 (0)