-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(test): onboard-session lock tests share tmpDir causing order dependence #1284
Copy link
Copy link
Open
Labels
NemoClaw CLIUse this label to identify issues with the NemoClaw command-line interface (CLI).Use this label to identify issues with the NemoClaw command-line interface (CLI).bugSomething isn't workingSomething isn't workingenhancement: testingUse this label to identify requests to improve NemoClaw test coverage.Use this label to identify requests to improve NemoClaw test coverage.
Description
Bug
In src/lib/onboard-session.test.ts, all lock tests share a single tmpDir. releaseOnboardLock() can leave malformed lock files behind, and the beforeEach hook only clears the module cache and session file — not the lock artifacts. This makes lock tests order-dependent.
Fix
Recreate tmpDir in beforeEach (or fs.rmSync + fs.mkdirSync) so each test starts clean.
Found by
CodeRabbit review on #1272. Pre-existing from original JS.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
NemoClaw CLIUse this label to identify issues with the NemoClaw command-line interface (CLI).Use this label to identify issues with the NemoClaw command-line interface (CLI).bugSomething isn't workingSomething isn't workingenhancement: testingUse this label to identify requests to improve NemoClaw test coverage.Use this label to identify requests to improve NemoClaw test coverage.