-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(test): restore port-resolution assertions in nimStatusByName tests #1280
Copy link
Copy link
Open
Labels
NemoClaw CLIUse this label to identify issues with the NemoClaw command-line interface (CLI).Use this label to identify issues with the NemoClaw command-line interface (CLI).bugSomething isn't workingSomething isn't workingenhancement: testingUse this label to identify requests to improve NemoClaw test coverage.Use this label to identify requests to improve NemoClaw test coverage.
Description
Bug
The TS migration in #1271 simplified the nimStatusByName test assertions, dropping the command-verification checks that validate port resolution branching:
- "falls back to 8000" no longer verifies
localhost:8000was actually used - "uses published docker port" no longer verifies
localhost:9000was used - "does not run health check when container is not running" no longer verifies docker port and health check commands were skipped
Without these, the tests just check healthy: true/false without confirming the port resolution logic picked the right port.
Fix
Restore the commands.some(cmd => cmd.includes(...)) assertions that were present in the original JS tests.
Found by
Review of #1271.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
NemoClaw CLIUse this label to identify issues with the NemoClaw command-line interface (CLI).Use this label to identify issues with the NemoClaw command-line interface (CLI).bugSomething isn't workingSomething isn't workingenhancement: testingUse this label to identify requests to improve NemoClaw test coverage.Use this label to identify requests to improve NemoClaw test coverage.