Skip to content

fix(test): restore port-resolution assertions in nimStatusByName tests #1280

@ericksoa

Description

@ericksoa

Bug

The TS migration in #1271 simplified the nimStatusByName test assertions, dropping the command-verification checks that validate port resolution branching:

  • "falls back to 8000" no longer verifies localhost:8000 was actually used
  • "uses published docker port" no longer verifies localhost:9000 was used
  • "does not run health check when container is not running" no longer verifies docker port and health check commands were skipped

Without these, the tests just check healthy: true/false without confirming the port resolution logic picked the right port.

Fix

Restore the commands.some(cmd => cmd.includes(...)) assertions that were present in the original JS tests.

Found by

Review of #1271.

Metadata

Metadata

Assignees

Labels

NemoClaw CLIUse this label to identify issues with the NemoClaw command-line interface (CLI).bugSomething isn't workingenhancement: testingUse this label to identify requests to improve NemoClaw test coverage.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions