Change prompt to try and get only topic names #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhinav Garg <[email protected]>
praateekmahajan
approved these changes
Apr 3, 2025
|
Hi yes, it works. But I said "try" since it's model-dependent. |
Comment on lines
+16
to
17
| DEFAULT_MACRO_TOPICS_PROMPT_TEMPLATE = "Can you generate {n_macro_topics} comprehensive topics that encompass various aspects of our daily life, the world, and science? Your answer should be a list of only topic name(s), nothing else. Make the topics as diverse as possible.For example, 1. Food and drinks. \n2. Technology.\n" | ||
|
|
There was a problem hiding this comment.
[nitpick] Consider inserting a space after the period in 'as diverse as possible.For example' to improve readability.
Suggested change
| DEFAULT_MACRO_TOPICS_PROMPT_TEMPLATE = "Can you generate {n_macro_topics} comprehensive topics that encompass various aspects of our daily life, the world, and science? Your answer should be a list of only topic name(s), nothing else. Make the topics as diverse as possible.For example, 1. Food and drinks. \n2. Technology.\n" | |
| DEFAULT_MACRO_TOPICS_PROMPT_TEMPLATE = "Can you generate {n_macro_topics} comprehensive topics that encompass various aspects of our daily life, the world, and science? Your answer should be a list of only topic name(s), nothing else. Make the topics as diverse as possible. For example, 1. Food and drinks. \n2. Technology.\n" |
Copilot uses AI. Check for mistakes.
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
sarahyurick
added
the
ray-api
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tries to fix #533. LLM gives output topics with descriptions. When we try to create a YAML, those descriptions sometimes get treated as separate topics. We modify the prompt to ask the LLM to just give the topic list.
Usage
# Add snippet demonstrating usageChecklist