Skip to content

Check permissions of pytest-tmp so GHA can process it #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 4, 2025
Merged

Check permissions of pytest-tmp so GHA can process it #1758

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
90c6b69
modify permissions to python tmp directory so gha can process it
Steboss Oct 30, 2025
3e22a9f
try to fix permissions after docker
Steboss Oct 30, 2025
f62a38b
try to run docker as current user
Steboss Oct 30, 2025
9db8802
try with a custom folder
Steboss Oct 31, 2025
abc4831
can we add the path too
Steboss Oct 31, 2025
5b1766c
simplify the approach adding rw
Steboss Oct 31, 2025
2bdffeb
change permissions after
Steboss Nov 3, 2025
ffa4855
test this
Steboss Nov 3, 2025
081fd82
test this
Steboss Nov 3, 2025
78021aa
simplify the ci
Steboss Nov 3, 2025
863888f
testing strategy
Steboss Nov 3, 2025
e92a964
add the path
Steboss Nov 3, 2025
2cf5b8a
restore ci
Steboss Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/_ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,21 +335,23 @@ jobs:
TEST_NAME: nsys-jax
EXECUTE: |
set -o pipefail
mkdir -p output-results
docker run -i --shm-size=1g --gpus all \
-v $PWD:/opt/output \
-v $PWD/output-results:/opt/output \
${{ needs.build-jax.outputs.DOCKER_TAG_FINAL }} \
bash <<"EOF" |& tee test-nsys-jax.log
# nsys-jax is already installed, this is just adding the test dependencies
pip install pytest-reportlog nsys-jax[test]
# abuse knowledge that nsys-jax is installed editable, so the tests exist
test_path=$(python -c 'import importlib.resources; print(importlib.resources.files("nsys_jax").joinpath("..", "tests").resolve())')
pytest --basetemp=/opt/output/pytest-tmp --report-log=/opt/output/pytest-report.jsonl "${test_path}"
chmod -R a+rwX /opt/output
EOF
STATISTICS_SCRIPT: |
summary_line=$(tail -n1 test-nsys-jax.log)
num_errors=$(echo $summary_line | grep -oE '[0-9]+ error' | awk '{print $1} END { if (!NR) print 0}')
passed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "passed") | .outcome' | wc -l)
failed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "failed") | .outcome' | wc -l)
passed_tests=$(cat output-results/pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "passed") | .outcome' | wc -l)
failed_tests=$(cat output-results/pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "failed") | .outcome' | wc -l)
total_tests=$(( passed_tests + failed_tests ))
echo "TOTAL_TESTS=${total_tests}" >> $GITHUB_OUTPUT
echo "ERRORS=${num_errors}" >> $GITHUB_OUTPUT
Expand All @@ -358,8 +360,8 @@ jobs:
ARTIFACTS: |
# pytest-driven part
test-nsys-jax.log
pytest-report.jsonl
pytest-tmp/
output-results/pytest-report.jsonl
output-results/pytest-tmp/
secrets: inherit

# test-nsys-jax generates several fresh .zip archive outputs by running nsys-jax with real GPU hardware; this test
Expand Down
Loading