Skip to content

Commit 80ccc49

Browse files
ko3n1gko3n1g
committed
style: Use single quotes
1 parent 82d00dd commit 80ccc49

File tree

2 files changed

+50
-52
lines changed

2 files changed

+50
-52
lines changed

‎.github/workflows/_test_rosetta_t5x.yaml‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,26 @@ on:
66
T5X_IMAGE:
77
type: string
88
description: T5X image from ghcr.io/nvidia/t5x
9-
default: "ghcr.io/nvidia/t5x:latest"
9+
default: 'ghcr.io/nvidia/t5x:latest'
1010
required: false
1111
BADGE_FILENAME:
1212
type: string
13-
description: "Name of the endpoint JSON file for shields.io badge"
13+
description: 'Name of the endpoint JSON file for shields.io badge'
1414
required: false
15-
default: "badge-rosetta-t5x-mgmn-test.json"
15+
default: 'badge-rosetta-t5x-mgmn-test.json'
1616
ARTIFACT_NAME:
1717
type: string
18-
description: "Name of the artifact zip file"
18+
description: 'Name of the artifact zip file'
1919
required: false
20-
default: "artifact-rosetta-t5x-mgmn-test"
20+
default: 'artifact-rosetta-t5x-mgmn-test'
2121
FW_NAME:
2222
type: string
23-
description: "Name of the framework being used"
23+
description: 'Name of the framework being used'
2424
required: false
25-
default: "rosetta-t5x"
25+
default: 'rosetta-t5x'
2626
outputs:
2727
TEST_STATUS:
28-
description: "Summary pass/fail value indicating if results from tests are acceptable"
28+
description: 'Summary pass/fail value indicating if results from tests are acceptable'
2929
value: ${{ jobs.sitrep.outputs.STATUS }}
3030

3131
env:
@@ -37,18 +37,18 @@ jobs:
3737
strategy:
3838
matrix:
3939
include:
40-
- TEST_NAME: "1P1G_te-1"
40+
- TEST_NAME: '1P1G_te-1'
4141
N_GPU: 1
42-
ADDITIONAL_ARGS: ""
43-
EXTRA_GIN_ARGS: "--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False"
44-
- TEST_NAME: "1P1G_te-0"
42+
ADDITIONAL_ARGS: ''
43+
EXTRA_GIN_ARGS: '--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False'
44+
- TEST_NAME: '1P1G_te-0'
4545
N_GPU: 1
46-
ADDITIONAL_ARGS: "--enable-te 0"
47-
EXTRA_GIN_ARGS: ""
48-
- TEST_NAME: "1P8G_te-1"
46+
ADDITIONAL_ARGS: '--enable-te 0'
47+
EXTRA_GIN_ARGS: ''
48+
- TEST_NAME: '1P8G_te-1'
4949
N_GPU: 8
50-
ADDITIONAL_ARGS: ""
51-
EXTRA_GIN_ARGS: "--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False"
50+
ADDITIONAL_ARGS: ''
51+
EXTRA_GIN_ARGS: '--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False'
5252
fail-fast: false
5353

5454
runs-on: ubuntu-22.04
@@ -233,26 +233,26 @@ jobs:
233233
strategy:
234234
matrix:
235235
include:
236-
- TEST_NAME: "1N1G-te-1"
236+
- TEST_NAME: '1N1G-te-1'
237237
N_GPU: 1
238238
N_NODE: 1
239-
ADDITIONAL_ARGS: ""
240-
EXTRA_GIN_ARGS: "--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False"
241-
- TEST_NAME: "1N8G-te-1"
239+
ADDITIONAL_ARGS: ''
240+
EXTRA_GIN_ARGS: '--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False'
241+
- TEST_NAME: '1N8G-te-1'
242242
N_GPU: 8
243243
N_NODE: 1
244-
ADDITIONAL_ARGS: ""
245-
EXTRA_GIN_ARGS: "--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False"
246-
- TEST_NAME: "2N8G-te-1"
244+
ADDITIONAL_ARGS: ''
245+
EXTRA_GIN_ARGS: '--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False'
246+
- TEST_NAME: '2N8G-te-1'
247247
N_GPU: 8
248248
N_NODE: 2
249-
ADDITIONAL_ARGS: ""
250-
EXTRA_GIN_ARGS: "--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False"
251-
- TEST_NAME: "2N2G_te-0"
249+
ADDITIONAL_ARGS: ''
250+
EXTRA_GIN_ARGS: '--gin.train/utils.DatasetConfig.pack=False --gin.train_eval/utils.DatasetConfig.pack=False'
251+
- TEST_NAME: '2N2G_te-0'
252252
N_GPU: 2
253253
N_NODE: 2
254-
ADDITIONAL_ARGS: "--enable-te 0"
255-
EXTRA_GIN_ARGS: ""
254+
ADDITIONAL_ARGS: '--enable-te 0'
255+
EXTRA_GIN_ARGS: ''
256256
fail-fast: false
257257

258258
runs-on: ubuntu-22.04
@@ -818,7 +818,7 @@ jobs:
818818
819819
sitrep:
820820
needs: metrics
821-
if: "!cancelled()"
821+
if: '!cancelled()'
822822
uses: ./.github/workflows/_sitrep_mgmn.yaml
823823
secrets: inherit
824824
with:
@@ -835,7 +835,7 @@ jobs:
835835
vit-single-process-multi-device,
836836
vit-multi-gpu-multi-node,
837837
]
838-
if: "!cancelled()"
838+
if: '!cancelled()'
839839
steps:
840840
- name: Generate TensorBoard query URL
841841
run: |
@@ -852,7 +852,7 @@ jobs:
852852
outcome:
853853
needs: sitrep
854854
runs-on: ubuntu-22.04
855-
if: "!cancelled()"
855+
if: '!cancelled()'
856856
steps:
857857
- name: Sets workflow status based on test outputs
858858
run: |
@@ -905,7 +905,7 @@ jobs:
905905
if: ( always() )
906906
secrets: inherit
907907
with:
908-
ENDPOINT_FILENAME: "rosetta-unit-test-status.json"
908+
ENDPOINT_FILENAME: 'rosetta-unit-test-status.json'
909909
PUBLISH: false
910910
SCRIPT: |
911911
ARTIFACTS="${{ needs.rosetta-unit-tests.outputs.TEST_ARTIFACT_NAME }}/*.jsonl"

‎.github/workflows/ci.yaml‎

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: CI
22

33
on:
44
schedule:
5-
- cron: '30 9 * * *' # Pacific Time 01:30 AM in UTC
5+
- cron: '30 9 * * *' # Pacific Time 01:30 AM in UTC
66
pull_request:
77
types:
88
- opened
@@ -25,7 +25,7 @@ on:
2525
required: false
2626
MERGE_BUMPED_MANIFEST:
2727
type: boolean
28-
description: "(used if BUMP_MANIFEST=true) If true: attempt to PR/merge manifest branch"
28+
description: '(used if BUMP_MANIFEST=true) If true: attempt to PR/merge manifest branch'
2929
default: false
3030
required: false
3131

@@ -34,16 +34,15 @@ concurrency:
3434
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
3535

3636
permissions:
37-
contents: write # to fetch code and push branch
38-
actions: write # to cancel previous workflows
39-
packages: write # to upload container
40-
pull-requests: write # to make pull request for manifest bump
37+
contents: write # to fetch code and push branch
38+
actions: write # to cancel previous workflows
39+
packages: write # to upload container
40+
pull-requests: write # to make pull request for manifest bump
4141

4242
env:
4343
DEFAULT_MANIFEST_ARTIFACT_NAME: bumped-manifest
4444

4545
jobs:
46-
4746
metadata:
4847
runs-on: ubuntu-22.04
4948
outputs:
@@ -115,7 +114,7 @@ jobs:
115114
shell: bash -x -e {0}
116115
run: |
117116
bash bump.sh --input-manifest manifest.yaml --output-manifest manifest.yaml.new --base-patch-dir ./patches-new
118-
117+
119118
- name: Maybe replace current manifest/patches with the new one and show diff
120119
working-directory: .github/container
121120
shell: bash -x -e {0}
@@ -168,12 +167,11 @@ jobs:
168167
steps:
169168
- name: "Tests Succeeded: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}"
170169
id: test_result
171-
run:
172-
echo "SUCCEEDED=${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}" | tee -a $GITHUB_OUTPUT
170+
run: echo "SUCCEEDED=${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}" | tee -a $GITHUB_OUTPUT
173171

174172
- name: Check out the repository under ${GITHUB_WORKSPACE}
175173
uses: actions/checkout@v4
176-
174+
177175
- name: Delete checked-out manifest and patches
178176
run: |
179177
rm .github/container/manifest.yaml
@@ -185,7 +183,7 @@ jobs:
185183
name: ${{ needs.metadata.outputs.MANIFEST_ARTIFACT_NAME }}
186184
path: .github/container/
187185

188-
- name: "Create local manifest branch: ${{ needs.metadata.outputs.MANIFEST_BRANCH }}"
186+
- name: 'Create local manifest branch: ${{ needs.metadata.outputs.MANIFEST_BRANCH }}'
189187
id: local_branch
190188
shell: bash -x -e {0}
191189
run: |
@@ -213,7 +211,7 @@ jobs:
213211
git merge --ff-only ${{ needs.metadata.outputs.MANIFEST_BRANCH }}
214212
# Push the new change
215213
git push origin ${{ github.ref_name }}
216-
214+
217215
# We will create a Draft PR & remote branch if:
218216
# 1. The tests failed
219217
# 2. The merge failed
@@ -244,12 +242,12 @@ jobs:
244242
draft: true
245243
env:
246244
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
247-
248-
- name: "Log created PR: #${{ fromJson(steps.create_pr.outputs.data).number }}"
245+
246+
- name: 'Log created PR: #${{ fromJson(steps.create_pr.outputs.data).number }}'
249247
if: steps.create_pr.outcome == 'success'
250248
run: |
251249
echo "https://github.com/NVIDIA/JAX-Toolbox/pull/${{ fromJson(steps.create_pr.outputs.data).number }}" | tee -a $GITHUB_STEP_SUMMARY
252-
250+
253251
# Guard delete in simple check to protect other branches
254252
- name: Check that the branch matches znightly- prefix
255253
run: |
@@ -271,7 +269,7 @@ jobs:
271269

272270
make-publish-configs:
273271
runs-on: ubuntu-22.04
274-
if: ${{ !cancelled() }}
272+
if: ${{ !cancelled() }}
275273
env:
276274
MEALKIT_IMAGE_REPO: ${{ needs.metadata.outputs.PUBLISH == 'true' && 'jax-mealkit' || 'mock-jax-mealkit' }}
277275
FINAL_IMAGE_REPO: ${{ needs.metadata.outputs.PUBLISH == 'true' && 'jax' || 'mock-jax' }}
@@ -365,7 +363,7 @@ jobs:
365363
needs:
366364
- metadata
367365
- make-publish-configs
368-
if: ${{ !cancelled() && needs.make-publish-configs.outputs.PUBLISH_CONFIGS.config != '{"config":[]}' }}
366+
if: ${{ !cancelled() && needs.make-publish-configs.outputs.PUBLISH_CONFIGS.config != '{"config":[]}' }}
369367
strategy:
370368
fail-fast: false
371369
matrix: ${{ fromJson(needs.make-publish-configs.outputs.PUBLISH_CONFIGS) }}
@@ -381,7 +379,7 @@ jobs:
381379
382380
finalize:
383381
needs: [metadata, amd64, arm64, publish-containers]
384-
if: "!cancelled()"
382+
if: '!cancelled()'
385383
uses: ./.github/workflows/_finalize.yaml
386384
with:
387385
BUILD_DATE: ${{ needs.metadata.outputs.BUILD_DATE }}

0 commit comments

Comments
 (0)