Repository navigation
Commit 8344885
committed
Fix trtllm rc28 API-drift breakage, regenerate uv.lock
Retested on GB200 (SLURM job 3126032) after the fixes: all 44 trtllm
unit tests pass (was 41 passed / 3 failed).
- tests/.../test_trtllm_backend.py: force the manual finalize fallback
in test_collective_refit_runs_at_async_engine_boundary via
`monkeypatch.setattr(backend.WorkerExtension, "finalize_weight_update",
None, raising=False)`. rc28's WorkerExtension now has
finalize_weight_update (rc21 didn't), so trtllm_backend.py's
_finalize_weight_update silently switched to that fast path and the
test's hardcoded call-order assertion (written only for the fallback)
started failing. Ported verbatim from the equivalent fix already
landing in #4122 (which adds the real
finalize_weight_update-aware FP8 refit logic later) — this commit
only makes the test deterministic across TRT-LLM versions, it does
not implement anything new.
- nemo_rl/models/generation/trtllm/trtllm_backend.py: import
control_action_decorator from tensorrt_llm.executor.ray.utils (the
rc28 location) with a fallback to the old tensorrt_llm._ray_utils
path. The old path still works but emits "will be removed in a
future release"; fixing now avoids a silent break on the next bump.
- uv.lock: regenerated against the bumped ref (was still rc21-era).
Resolves cleanly (529 packages), confirms tensorrt/tensorrt-cu13/
tensorrt-cu13-bindings/tensorrt-cu13-libs are no longer pulled in
(matches upstream dropping its own tensorrt pin). Note: it resolves
torch and nvidia-cudnn-frontend via this repo's override-dependencies
(torch==2.11.0+cu130, nvidia-cudnn-frontend==1.25.0) rather than what
TRT-LLM's own dependencies actually declare (torch>=2.13.0,
nvidia-cudnn-frontend>=1.27.0) — uv's override mechanism forces the
version project-wide without validating the sub-dependency is
actually satisfied. This is the same conflict already flagged in
3rdparty/TensorRT-LLM-workspace/pyproject.toml's "KNOWN UNRESOLVED
CONFLICTS" comment; still unresolved, not addressed by this commit.
Signed-off-by: Erin Ho <14718778+hchings@users.noreply.github.com>1 parent bcf611d commit 8344885
3 files changed
Lines changed: 709 additions & 1493 deletions
File tree
- nemo_rl/models/generation/trtllm
- tests/unit/models/generation/trtllm
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
34 | 40 | | |
35 | 41 | | |
36 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
97 | 104 | | |
98 | 105 | | |
99 | 106 | | |
| |||
0 commit comments