Repository navigation
Commit 0807be9
committed
test(trtllm): pin two tests to a deterministic TRT-LLM capability state
Both passed only by accident against the sandboxed/old-pin CI environment
and failed when actually run against an installed TRT-LLM carrying the full
RL refit lifecycle:
- test_collective_refit_runs_at_async_engine_boundary asserted a call order
that only holds when WorkerExtension.finalize_weight_update is absent, but
never forced that fallback path (unlike the sibling
test_refit_finalization_falls_back_for_older_trtllm, which does). Force it
explicitly.
- test_collective_refit_always_resets_prefix_cache used a bare MagicMock
engine, which auto-creates recompute_active_requests and masks the
reset_prefix_cache fallback its name asserts. Delete the attribute so
absence is real.
Verified: all 72 trtllm-marked tests in tests/unit/models/generation/trtllm/
pass against a real tekit-backed TRT-LLM install (job 3074375).
Signed-off-by: Erin Ho <14718778+hchings@users.noreply.github.com>1 parent a0f1cdb commit 0807be9
2 files changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
130 | 137 | | |
131 | 138 | | |
132 | 139 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
| |||
0 commit comments