-
Notifications
You must be signed in to change notification settings - Fork 26
Implement automatic model calibration #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…atLabRockies#199) * Adding at the root level for now; could consider moving to utilities/ * Ruff. * precommit stuff. * Add example notebook * Add wide to long * Add test * Update README.md engagement * Update README.md replacing 'FLORIS' typo * Feature/add docstrings (NatLabRockies#197) * Update to 15 (NatLabRockies#202) * Update for PyPI installation. (NatLabRockies#204) * Update version number; ignore version.py for ruff. * Adhere to FLASC formatting rules. * psuedocode for conversions. Tests for saving dataframe to file. * Print warning when to_feather used. * String formatting. * Add several more tests and n_turbines property. * Adding TODOs for long/wide conversions. * Clean up, a few more tests. * Improved printout. * ruff format. --------- Co-authored-by: Paul <paul.fleming@nrel.gov> Co-authored-by: christiannvaughn <139596563+christiannvaughn@users.noreply.github.com>
|
First follow-up comment is the ResultsAnalysis is out |
|
@paulf81 regarding the |
|
@misi9170 on |
I guess I'm not really seeing what it's adding compared to just actually instantiating a |
Ok, I'll kill it |
|
Also I tracked down the parallel thing, in very early versions of things, we were converting all Question for you @misi9170, do you think useful to include a parallel example that does use |
On second thought I found where it's used in the |
Implement automatic model calibration
This pull request adds a new class to FLASC:
ModelFit. Currently under development the new class implements a new paradigm for automatic model calibration. The PR includes new examples and will include additional documentation.Checklist of work to go:
Review of changes
Unrelated linting-type changes that got grouped in
Flying below the radar
results_analysis.py, which was useful for conducting analysis of results generated from model_fit in other projects in included but not yet linked into any examples or docs. This is probably ok for this first pass.Feature or improvement description
This PR replaces #213