Skip to content

Fix an unskip GFSPhysicsDriver translate test #66

@romanc

Description

@romanc

Describe the bug

The translate test for GFSPhysicsDriver wasn't properly registered and thus the NDSL's translate test system automatically marked it as xfail (expected failure) because it couldn't find the translate test class. The behavior only started to show after some typing work in NDSL, which made things more strict.

In PR #65 we thus properly registered the translate test and once it was running, it failed in numerical validation. The translate test was thus properly skipped and show now be looked at, fixed and unskipped.

To Reproduce

Unskip the translate test for GFSPhysicsDriver. PR #65 contains a link here and instructions to unskip the test.

Expected behavior

We expect the translate test of GFSPhysicsDriver to run and pass.

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions