Allow virtual flux correction based on ocean salt restoring/correction#35
Open
dougiesquire wants to merge 1 commit into
Open
Conversation
…c_?_update_from_coupler routine Allow virtual tracer flux adjustments
Author
|
Just a note that the MOM5 changes needed to utilize the changes in this PR have been approved. Merging the MOM5 changes but not the changes in this PR will mean that the latest version of MOM5 will no longer work with the generic tracers in this repo. |
Author
|
It would be helpful to know if this might get reviewed/merged one day, or if this is something we'll just have to maintain in our own fork. @theresa-cordero, @yichengt900 Note that in the case of the latter:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements changes that allow
stfadjustments based on any salt restoring/correction applied by the ocean model. There are two changes in this PR:generic_tracer::generic_tracer_update_from_couplerroutine has been added. This receives the salt flux restoring/correction applied by the ocean and passes it on to the generic tracer'supdate_from_couplerroutine.flux_virtualhas been added to thegeneric_tracer_utils::g_tracer_addroutine. If true, this ensures that thestffield is allocated on the tracer being added.Unfortunately, changes are needed to the calling ocean model in order to utilize the changes in this PR:
generic_tracer::generic_tracer_coupler_getis replaced by a call togeneric_tracer::generic_tracer_coupler_accumulateand thengeneric_tracer::generic_tracer_update_from_coupleris called as part ofocean_sbc_mod::flux_adjust. See here for the changes.generic_tracer::generic_tracer_update_from_coupleris called inMOM_generic_tracer::MOM_generic_tracer_column_physics. See here for the changes.Merging this PR but not changing the ocean model will mean no change from current behaviour.
Closes #32