Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlighted the current page item on navebar #303

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

highlighted the current page item on navebar #303

wants to merge 25 commits into from

Conversation

Isaac3105
Copy link
Contributor

Closes #300

Now, if your current page is one of the pages from navebar, the corresponding item from the navebar will be highlighted.
image

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@Isaac3105 Isaac3105 assigned Isaac3105 and unassigned Isaac3105 Nov 30, 2024
MRita443
MRita443 requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I left some suggestion as to how you can make this even better :)

src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
rubuy-74
rubuy-74 requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, there are just some small things that could be a little different.

src/routes/(app)/_components/layout/navbar.svelte Show resolved Hide resolved
src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
@rubuy-74
Copy link
Contributor

rubuy-74 commented Jan 8, 2025

Another thing, now that the navbar has state, it should be nice to have some storybook tests. There are some examples already in the codebase but you can also use the documentation as reference.

https://storybook.js.org/docs/writing-tests

@MRita443 MRita443 self-requested a review January 17, 2025 16:54
@Isaac3105 Isaac3105 self-assigned this Jan 26, 2025
@Isaac3105 Isaac3105 requested a review from rubuy-74 January 26, 2025 14:35
MRita443
MRita443 requested changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, nearly done!

src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
src/routes/(app)/_components/layout/navbar.svelte Outdated Show resolved Hide resolved
src/routes/(app)/_components/layout/navbar.svelte Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 155 lines in your changes missing coverage. Please review.

Project coverage is 0.55%. Comparing base (30d2237) to head (42c1369).
Report is 38 commits behind head on develop.

Files with missing lines Patch % Lines
public/mockServiceWorker.js 0.00% 95 Missing ⚠️
src/routes/(app)/_components/layout/navbar.svelte 0.00% 26 Missing ⚠️
.../routes/(app)/_components/layout/navbar.stories.ts 0.00% 21 Missing and 1 partial ⚠️
src/routes/(app)/layout.stories.ts 0.00% 10 Missing ⚠️
src/routes/(app)/(home)/page.stories.ts 0.00% 0 Missing and 1 partial ⚠️
src/routes/(app)/login/page.stories.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           develop    #303      +/-   ##
==========================================
- Coverage     0.65%   0.55%   -0.11%     
==========================================
  Files           63      64       +1     
  Lines         2430    2888     +458     
  Branches        65      66       +1     
==========================================
  Hits            16      16              
- Misses        2353    2810     +457     
- Partials        61      62       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Isaac3105 Isaac3105 requested a review from MRita443 February 12, 2025 16:59
@peucastro peucastro mentioned this pull request Feb 12, 2025
Open
3 tasks
MRita443
MRita443 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRita443 MRita443 MRita443 approved these changes

@rubuy-74 rubuy-74 Awaiting requested review from rubuy-74

Requested changes must be addressed to merge this pull request.

Assignees

@Isaac3105 Isaac3105

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

navbar: highlight current page
3 participants
@Isaac3105 @rubuy-74 @MRita443