warning message "problem with spitfire fuel averaging" is spamming

[rgknox]

I'm running an 4x5 degree test run, and the land log is full of the "problem with spitfire fuel averaging" message.

EDIT: This must be where the warning message is printing: https://github.com/NGEET/fates/blob/sci.1.70.0_api.32.0.0/fire/SFMainMod.F90#L337

Here is the logic where it triggers the warning:

https://github.com/NGEET/fates/blob/sci.1.70.0_api.32.0.0/fire/SFMainMod.F90#L240

As far as I can tell, this seems like a very normal and possible scenario. Some terra firma locations on this earth have no vegetation, and therefore no litter, so no fuel. Should we just remove this warning?

@rosiealice @adrifoster

[rosiealice]

Hi Ryan,

I think it's perhaps a little wierder than you describe, as the properties that are checked here are mostly all set to some small positive number in the section above if the fuel is zero, and so what is going on here must mean that these average properties must be zero or negative, which I think might mean that the contingency for the zero fuel case in the section above isn't working?
(Or that there is fuel and the fuel property averaging is broken for the case where there is fuel?)

A better contingency would probably include not actually trying to use the average fuel properties at all in the case that there is no fuel, but that might make e.g, averaging over the patches annoying?