Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor issue: acc_hold cohort variables should not be zero'd #1113

Closed
rgknox opened this issue Nov 3, 2023 · 0 comments · Fixed by #1114
Closed

minor issue: acc_hold cohort variables should not be zero'd #1113

rgknox opened this issue Nov 3, 2023 · 0 comments · Fixed by #1114

Comments

@rgknox
Copy link
Contributor

rgknox commented Nov 3, 2023

Variables labeled "_acc_hold" are being zero'd in the group zero'ing calls. These variables are not built or iterated, so they don't need to be zero'd, its safer to leave them as nan's so they aren't used without proper initialization. They were indeed being used in the history routine, and in the routine where we calculate a smoothed NPP (for fixation calculations in the hlm), and newly created cohorts that had not experienced a day of productivity were being asked for these values (inappropriately). This will slightly under-bias the history output values since the zeros will be mixed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant