From 8e3931d6077aa0538db89765d89f26d64dd05e0e Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Thu, 15 Jun 2023 17:09:50 +0200 Subject: [PATCH 1/9] Refresh apt cache if package is not yet installed I know, checking for the existence of the configuration directory is not the best way. But it's way faster than quering the package manager every time. fixes #167 --- roles/beats/tasks/auditbeat.yml | 15 +++++++++++++++ roles/beats/tasks/filebeat.yml | 15 +++++++++++++++ roles/beats/tasks/metricbeat.yml | 15 +++++++++++++++ roles/elasticsearch/tasks/main.yml | 16 ++++++++++++++++ roles/kibana/tasks/main.yml | 15 +++++++++++++++ roles/logstash/tasks/main.yml | 15 +++++++++++++++ 6 files changed, 91 insertions(+) diff --git a/roles/beats/tasks/auditbeat.yml b/roles/beats/tasks/auditbeat.yml index 01ba5d84..5c744e6a 100644 --- a/roles/beats/tasks/auditbeat.yml +++ b/roles/beats/tasks/auditbeat.yml @@ -1,5 +1,20 @@ --- +- name: Update apt cache if package is not installed + when: + - ansible_os_family == "Debian" + block: + + - name: Check for existence of auditbeat configuration directory + stat: + path: "/etc/auditbeat" + register: auditbeat_configdir_stat + + - name: Refresh apt cache if config dir is missing + apt: + refresh_cache: yes + when: not auditbeat_configdir_stat.exists + - name: Construct exact name of Auditbeat package set_fact: beats_auditbeat_package: > diff --git a/roles/beats/tasks/filebeat.yml b/roles/beats/tasks/filebeat.yml index 13a4ff4b..053e0c63 100644 --- a/roles/beats/tasks/filebeat.yml +++ b/roles/beats/tasks/filebeat.yml @@ -1,5 +1,20 @@ --- +- name: Update apt cache if package is not installed + when: + - ansible_os_family == "Debian" + block: + + - name: Check for existence of filebeat configuration directory + stat: + path: "/etc/filebeat" + register: beats_filebeat_configdir_stat + + - name: Refresh apt cache if config dir is missing + apt: + refresh_cache: yes + when: not beats_filebeat_configdir_stat.exists + - name: Construct exact name of Filebeat package set_fact: beats_filebeat_package: > diff --git a/roles/beats/tasks/metricbeat.yml b/roles/beats/tasks/metricbeat.yml index 67e26661..31a2b684 100644 --- a/roles/beats/tasks/metricbeat.yml +++ b/roles/beats/tasks/metricbeat.yml @@ -1,5 +1,20 @@ --- +- name: Update apt cache if package is not installed + when: + - ansible_os_family == "Debian" + block: + + - name: Check for existence of metricbeat configuration directory + stat: + path: "/etc/metricbeat" + register: beats_metricbeat_configdir_stat + + - name: Refresh apt cache if config dir is missing + apt: + refresh_cache: yes + when: not beats_metricbeat_configdir_stat.exists + - name: Construct exact name of Metricbeat package set_fact: beats_metricbeat_package: > diff --git a/roles/elasticsearch/tasks/main.yml b/roles/elasticsearch/tasks/main.yml index e23e8151..73d23b76 100644 --- a/roles/elasticsearch/tasks/main.yml +++ b/roles/elasticsearch/tasks/main.yml @@ -1,4 +1,20 @@ --- + +- name: Update apt cache if package is not installed + when: + - ansible_os_family == "Debian" + block: + + - name: Check for existence of elasticsearch configuration directory + stat: + path: "/etc/elasticsearch" + register: elasticsearch_configdir_stat + + - name: Refresh apt cache if config dir is missing + apt: + refresh_cache: yes + when: not elasticsearch_configdir_stat.exists + - name: Check-set-parameters ansible.builtin.include_tasks: elasticsearch-parameters.yml diff --git a/roles/kibana/tasks/main.yml b/roles/kibana/tasks/main.yml index 12c78280..663a82d9 100644 --- a/roles/kibana/tasks/main.yml +++ b/roles/kibana/tasks/main.yml @@ -1,5 +1,20 @@ --- +- name: Update apt cache if package is not installed + when: + - ansible_os_family == "Debian" + block: + + - name: Check for existence of kibana configuration directory + stat: + path: "/etc/kibana" + register: kibana_configdir_stat + + - name: Refresh apt cache if config dir is missing + apt: + refresh_cache: yes + when: not kibana_configdir_stat.exists + - name: Include OS specific vars include_vars: '{{ item }}' with_first_found: diff --git a/roles/logstash/tasks/main.yml b/roles/logstash/tasks/main.yml index fd95b509..b24f9a20 100644 --- a/roles/logstash/tasks/main.yml +++ b/roles/logstash/tasks/main.yml @@ -1,5 +1,20 @@ --- +- name: Update apt cache if package is not installed + when: + - ansible_os_family == "Debian" + block: + + - name: Check for existence of logstash configuration directory + stat: + path: "/etc/logstash" + register: logstash_configdir_stat + + - name: Refresh apt cache if config dir is missing + apt: + refresh_cache: yes + when: not logstash_configdir_stat.exists + - name: Include OS specific vars include_vars: '{{ item }}' with_first_found: From af9490329cd36c1366c252256bbafe703fee40e5 Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Thu, 15 Jun 2023 17:16:40 +0200 Subject: [PATCH 2/9] Typo --- roles/beats/tasks/auditbeat.yml | 2 +- roles/beats/tasks/filebeat.yml | 2 +- roles/beats/tasks/metricbeat.yml | 2 +- roles/elasticsearch/tasks/main.yml | 2 +- roles/kibana/tasks/main.yml | 2 +- roles/logstash/tasks/main.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/roles/beats/tasks/auditbeat.yml b/roles/beats/tasks/auditbeat.yml index 5c744e6a..552d6a3d 100644 --- a/roles/beats/tasks/auditbeat.yml +++ b/roles/beats/tasks/auditbeat.yml @@ -13,7 +13,7 @@ - name: Refresh apt cache if config dir is missing apt: refresh_cache: yes - when: not auditbeat_configdir_stat.exists + when: not auditbeat_configdir_stat.stat.exists - name: Construct exact name of Auditbeat package set_fact: diff --git a/roles/beats/tasks/filebeat.yml b/roles/beats/tasks/filebeat.yml index 053e0c63..5f643ec7 100644 --- a/roles/beats/tasks/filebeat.yml +++ b/roles/beats/tasks/filebeat.yml @@ -13,7 +13,7 @@ - name: Refresh apt cache if config dir is missing apt: refresh_cache: yes - when: not beats_filebeat_configdir_stat.exists + when: not beats_filebeat_configdir_stat.stat.exists - name: Construct exact name of Filebeat package set_fact: diff --git a/roles/beats/tasks/metricbeat.yml b/roles/beats/tasks/metricbeat.yml index 31a2b684..0e0568cc 100644 --- a/roles/beats/tasks/metricbeat.yml +++ b/roles/beats/tasks/metricbeat.yml @@ -13,7 +13,7 @@ - name: Refresh apt cache if config dir is missing apt: refresh_cache: yes - when: not beats_metricbeat_configdir_stat.exists + when: not beats_metricbeat_configdir_stat.stat.exists - name: Construct exact name of Metricbeat package set_fact: diff --git a/roles/elasticsearch/tasks/main.yml b/roles/elasticsearch/tasks/main.yml index 73d23b76..96abf37b 100644 --- a/roles/elasticsearch/tasks/main.yml +++ b/roles/elasticsearch/tasks/main.yml @@ -13,7 +13,7 @@ - name: Refresh apt cache if config dir is missing apt: refresh_cache: yes - when: not elasticsearch_configdir_stat.exists + when: not elasticsearch_configdir_stat.stat.exists - name: Check-set-parameters ansible.builtin.include_tasks: elasticsearch-parameters.yml diff --git a/roles/kibana/tasks/main.yml b/roles/kibana/tasks/main.yml index 663a82d9..0d510229 100644 --- a/roles/kibana/tasks/main.yml +++ b/roles/kibana/tasks/main.yml @@ -13,7 +13,7 @@ - name: Refresh apt cache if config dir is missing apt: refresh_cache: yes - when: not kibana_configdir_stat.exists + when: not kibana_configdir_stat.stat.exists - name: Include OS specific vars include_vars: '{{ item }}' diff --git a/roles/logstash/tasks/main.yml b/roles/logstash/tasks/main.yml index b24f9a20..28026084 100644 --- a/roles/logstash/tasks/main.yml +++ b/roles/logstash/tasks/main.yml @@ -13,7 +13,7 @@ - name: Refresh apt cache if config dir is missing apt: refresh_cache: yes - when: not logstash_configdir_stat.exists + when: not logstash_configdir_stat.stat.exists - name: Include OS specific vars include_vars: '{{ item }}' From af9e1392444b8a5b6847800b9c24918dacc5df79 Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Thu, 15 Jun 2023 17:32:14 +0200 Subject: [PATCH 3/9] Typo --- roles/beats/tasks/auditbeat.yml | 2 +- roles/beats/tasks/filebeat.yml | 2 +- roles/beats/tasks/metricbeat.yml | 2 +- roles/elasticsearch/tasks/main.yml | 2 +- roles/kibana/tasks/main.yml | 2 +- roles/logstash/tasks/main.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/roles/beats/tasks/auditbeat.yml b/roles/beats/tasks/auditbeat.yml index 552d6a3d..4c067daf 100644 --- a/roles/beats/tasks/auditbeat.yml +++ b/roles/beats/tasks/auditbeat.yml @@ -12,7 +12,7 @@ - name: Refresh apt cache if config dir is missing apt: - refresh_cache: yes + update_cache: yes when: not auditbeat_configdir_stat.stat.exists - name: Construct exact name of Auditbeat package diff --git a/roles/beats/tasks/filebeat.yml b/roles/beats/tasks/filebeat.yml index 5f643ec7..6b804f4e 100644 --- a/roles/beats/tasks/filebeat.yml +++ b/roles/beats/tasks/filebeat.yml @@ -12,7 +12,7 @@ - name: Refresh apt cache if config dir is missing apt: - refresh_cache: yes + update_cache: yes when: not beats_filebeat_configdir_stat.stat.exists - name: Construct exact name of Filebeat package diff --git a/roles/beats/tasks/metricbeat.yml b/roles/beats/tasks/metricbeat.yml index 0e0568cc..55ce6fc5 100644 --- a/roles/beats/tasks/metricbeat.yml +++ b/roles/beats/tasks/metricbeat.yml @@ -12,7 +12,7 @@ - name: Refresh apt cache if config dir is missing apt: - refresh_cache: yes + update_cache: yes when: not beats_metricbeat_configdir_stat.stat.exists - name: Construct exact name of Metricbeat package diff --git a/roles/elasticsearch/tasks/main.yml b/roles/elasticsearch/tasks/main.yml index 96abf37b..a67eb907 100644 --- a/roles/elasticsearch/tasks/main.yml +++ b/roles/elasticsearch/tasks/main.yml @@ -12,7 +12,7 @@ - name: Refresh apt cache if config dir is missing apt: - refresh_cache: yes + update_cache: yes when: not elasticsearch_configdir_stat.stat.exists - name: Check-set-parameters diff --git a/roles/kibana/tasks/main.yml b/roles/kibana/tasks/main.yml index 0d510229..c3c3a66e 100644 --- a/roles/kibana/tasks/main.yml +++ b/roles/kibana/tasks/main.yml @@ -12,7 +12,7 @@ - name: Refresh apt cache if config dir is missing apt: - refresh_cache: yes + update_cache: yes when: not kibana_configdir_stat.stat.exists - name: Include OS specific vars diff --git a/roles/logstash/tasks/main.yml b/roles/logstash/tasks/main.yml index 28026084..d3d128d1 100644 --- a/roles/logstash/tasks/main.yml +++ b/roles/logstash/tasks/main.yml @@ -12,7 +12,7 @@ - name: Refresh apt cache if config dir is missing apt: - refresh_cache: yes + update_cache: yes when: not logstash_configdir_stat.stat.exists - name: Include OS specific vars From a25b603f4f5afbf8363d80e0114c38afe87ba933 Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Tue, 22 Aug 2023 17:11:16 +0200 Subject: [PATCH 4/9] Replace hacky check with cached refresh --- roles/beats/tasks/auditbeat.yml | 15 --------------- roles/beats/tasks/filebeat.yml | 15 --------------- roles/beats/tasks/main.yml | 6 ++++++ roles/beats/tasks/metricbeat.yml | 15 --------------- roles/elasticsearch/tasks/main.yml | 19 +++++-------------- roles/kibana/tasks/main.yml | 19 +++++-------------- roles/logstash/tasks/main.yml | 19 +++++-------------- 7 files changed, 21 insertions(+), 87 deletions(-) diff --git a/roles/beats/tasks/auditbeat.yml b/roles/beats/tasks/auditbeat.yml index 4c067daf..01ba5d84 100644 --- a/roles/beats/tasks/auditbeat.yml +++ b/roles/beats/tasks/auditbeat.yml @@ -1,20 +1,5 @@ --- -- name: Update apt cache if package is not installed - when: - - ansible_os_family == "Debian" - block: - - - name: Check for existence of auditbeat configuration directory - stat: - path: "/etc/auditbeat" - register: auditbeat_configdir_stat - - - name: Refresh apt cache if config dir is missing - apt: - update_cache: yes - when: not auditbeat_configdir_stat.stat.exists - - name: Construct exact name of Auditbeat package set_fact: beats_auditbeat_package: > diff --git a/roles/beats/tasks/filebeat.yml b/roles/beats/tasks/filebeat.yml index 76ad47ae..77d53815 100644 --- a/roles/beats/tasks/filebeat.yml +++ b/roles/beats/tasks/filebeat.yml @@ -1,20 +1,5 @@ --- -- name: Update apt cache if package is not installed - when: - - ansible_os_family == "Debian" - block: - - - name: Check for existence of filebeat configuration directory - stat: - path: "/etc/filebeat" - register: beats_filebeat_configdir_stat - - - name: Refresh apt cache if config dir is missing - apt: - update_cache: yes - when: not beats_filebeat_configdir_stat.stat.exists - - name: Construct exact name of Filebeat package set_fact: beats_filebeat_package: > diff --git a/roles/beats/tasks/main.yml b/roles/beats/tasks/main.yml index 514a3b1d..1ebaea05 100644 --- a/roles/beats/tasks/main.yml +++ b/roles/beats/tasks/main.yml @@ -6,6 +6,12 @@ - '{{ ansible_os_family }}_{{ ansible_distribution_major_version }}.yml' - '{{ ansible_os_family }}.yml' +- name: Update apt cache. + apt: + update_cache: yes + cache_valid_time: 600 + when: ansible_os_family == 'Debian' + - name: Prepare for whole stack roles if used when: - elasticstack_full_stack | bool diff --git a/roles/beats/tasks/metricbeat.yml b/roles/beats/tasks/metricbeat.yml index 55ce6fc5..67e26661 100644 --- a/roles/beats/tasks/metricbeat.yml +++ b/roles/beats/tasks/metricbeat.yml @@ -1,20 +1,5 @@ --- -- name: Update apt cache if package is not installed - when: - - ansible_os_family == "Debian" - block: - - - name: Check for existence of metricbeat configuration directory - stat: - path: "/etc/metricbeat" - register: beats_metricbeat_configdir_stat - - - name: Refresh apt cache if config dir is missing - apt: - update_cache: yes - when: not beats_metricbeat_configdir_stat.stat.exists - - name: Construct exact name of Metricbeat package set_fact: beats_metricbeat_package: > diff --git a/roles/elasticsearch/tasks/main.yml b/roles/elasticsearch/tasks/main.yml index 28d8865c..ca5a0493 100644 --- a/roles/elasticsearch/tasks/main.yml +++ b/roles/elasticsearch/tasks/main.yml @@ -1,19 +1,10 @@ --- -- name: Update apt cache if package is not installed - when: - - ansible_os_family == "Debian" - block: - - - name: Check for existence of elasticsearch configuration directory - stat: - path: "/etc/elasticsearch" - register: elasticsearch_configdir_stat - - - name: Refresh apt cache if config dir is missing - apt: - update_cache: yes - when: not elasticsearch_configdir_stat.stat.exists +- name: Update apt cache. + apt: + update_cache: yes + cache_valid_time: 600 + when: ansible_os_family == 'Debian' - name: Check-set-parameters ansible.builtin.include_tasks: elasticsearch-parameters.yml diff --git a/roles/kibana/tasks/main.yml b/roles/kibana/tasks/main.yml index c3c3a66e..14e4b091 100644 --- a/roles/kibana/tasks/main.yml +++ b/roles/kibana/tasks/main.yml @@ -1,19 +1,10 @@ --- -- name: Update apt cache if package is not installed - when: - - ansible_os_family == "Debian" - block: - - - name: Check for existence of kibana configuration directory - stat: - path: "/etc/kibana" - register: kibana_configdir_stat - - - name: Refresh apt cache if config dir is missing - apt: - update_cache: yes - when: not kibana_configdir_stat.stat.exists +- name: Update apt cache. + apt: + update_cache: yes + cache_valid_time: 600 + when: ansible_os_family == 'Debian' - name: Include OS specific vars include_vars: '{{ item }}' diff --git a/roles/logstash/tasks/main.yml b/roles/logstash/tasks/main.yml index d3d128d1..94a66da0 100644 --- a/roles/logstash/tasks/main.yml +++ b/roles/logstash/tasks/main.yml @@ -1,19 +1,10 @@ --- -- name: Update apt cache if package is not installed - when: - - ansible_os_family == "Debian" - block: - - - name: Check for existence of logstash configuration directory - stat: - path: "/etc/logstash" - register: logstash_configdir_stat - - - name: Refresh apt cache if config dir is missing - apt: - update_cache: yes - when: not logstash_configdir_stat.stat.exists +- name: Update apt cache. + apt: + update_cache: yes + cache_valid_time: 600 + when: ansible_os_family == 'Debian' - name: Include OS specific vars include_vars: '{{ item }}' From 9579b413b020e795c95f5a414e6e66aa9f4f6b36 Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Wed, 23 Aug 2023 10:42:58 +0200 Subject: [PATCH 5/9] Fix deprecated module name Thanks @dnssmr --- molecule/elasticstack_default/converge.yml | 4 +++- roles/beats/tasks/main.yml | 2 +- roles/elasticsearch/tasks/main.yml | 2 +- roles/kibana/tasks/main.yml | 2 +- roles/logstash/tasks/main.yml | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/molecule/elasticstack_default/converge.yml b/molecule/elasticstack_default/converge.yml index e82ed39b..1d69a093 100644 --- a/molecule/elasticstack_default/converge.yml +++ b/molecule/elasticstack_default/converge.yml @@ -28,7 +28,9 @@ elasticstack_rpm_workaround: true when: ansible_os_family == 'RedHat' and ansible_distribution_major_version >= "9" - name: Update apt cache. - apt: update_cache=yes cache_valid_time=600 + ansible.builtin.apt: + update_cache: yes + cache_valid_time: 600 when: ansible_os_family == 'Debian' - name: Install dependencies package: diff --git a/roles/beats/tasks/main.yml b/roles/beats/tasks/main.yml index 94049064..02e00773 100644 --- a/roles/beats/tasks/main.yml +++ b/roles/beats/tasks/main.yml @@ -7,7 +7,7 @@ - '{{ ansible_os_family }}.yml' - name: Update apt cache. - apt: + ansible.builtin.apt: update_cache: yes cache_valid_time: 600 when: ansible_os_family == 'Debian' diff --git a/roles/elasticsearch/tasks/main.yml b/roles/elasticsearch/tasks/main.yml index ef90c4dc..f0e33bbd 100644 --- a/roles/elasticsearch/tasks/main.yml +++ b/roles/elasticsearch/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Update apt cache. - apt: + ansible.builtin.apt: update_cache: yes cache_valid_time: 600 when: ansible_os_family == 'Debian' diff --git a/roles/kibana/tasks/main.yml b/roles/kibana/tasks/main.yml index 54807df2..8610f6ab 100644 --- a/roles/kibana/tasks/main.yml +++ b/roles/kibana/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Update apt cache. - apt: + ansible.builtin.apt: update_cache: yes cache_valid_time: 600 when: ansible_os_family == 'Debian' diff --git a/roles/logstash/tasks/main.yml b/roles/logstash/tasks/main.yml index 34d793df..9c03d72c 100644 --- a/roles/logstash/tasks/main.yml +++ b/roles/logstash/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Update apt cache. - apt: + ansible.builtin.apt: update_cache: yes cache_valid_time: 600 when: ansible_os_family == 'Debian' From 7223d128be28485aaa120eb75a72e9e9576b9bfe Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Wed, 23 Aug 2023 16:52:52 +0200 Subject: [PATCH 6/9] Disable change for apt refresh Apt refresh broke idempotence tests in another branch --- roles/beats/tasks/main.yml | 1 + roles/elasticsearch/tasks/main.yml | 1 + roles/kibana/tasks/main.yml | 1 + roles/logstash/tasks/main.yml | 1 + 4 files changed, 4 insertions(+) diff --git a/roles/beats/tasks/main.yml b/roles/beats/tasks/main.yml index 02e00773..41ab931d 100644 --- a/roles/beats/tasks/main.yml +++ b/roles/beats/tasks/main.yml @@ -10,6 +10,7 @@ ansible.builtin.apt: update_cache: yes cache_valid_time: 600 + changed_when: false when: ansible_os_family == 'Debian' - name: Prepare for whole stack roles if used diff --git a/roles/elasticsearch/tasks/main.yml b/roles/elasticsearch/tasks/main.yml index f0e33bbd..d6ac2255 100644 --- a/roles/elasticsearch/tasks/main.yml +++ b/roles/elasticsearch/tasks/main.yml @@ -4,6 +4,7 @@ ansible.builtin.apt: update_cache: yes cache_valid_time: 600 + changed_when: false when: ansible_os_family == 'Debian' - name: Check-set-parameters diff --git a/roles/kibana/tasks/main.yml b/roles/kibana/tasks/main.yml index 8610f6ab..c5982650 100644 --- a/roles/kibana/tasks/main.yml +++ b/roles/kibana/tasks/main.yml @@ -4,6 +4,7 @@ ansible.builtin.apt: update_cache: yes cache_valid_time: 600 + changed_when: false when: ansible_os_family == 'Debian' - name: Include OS specific vars diff --git a/roles/logstash/tasks/main.yml b/roles/logstash/tasks/main.yml index 9c03d72c..dc8d2790 100644 --- a/roles/logstash/tasks/main.yml +++ b/roles/logstash/tasks/main.yml @@ -4,6 +4,7 @@ ansible.builtin.apt: update_cache: yes cache_valid_time: 600 + changed_when: false when: ansible_os_family == 'Debian' - name: Include OS specific vars From abc722b4ba6c0091ed5e8afe59e32589c1fa0d31 Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Wed, 23 Aug 2023 16:55:38 +0200 Subject: [PATCH 7/9] Disable changed for apt update It breaks idempotence tests --- molecule/elasticstack_default/converge.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/molecule/elasticstack_default/converge.yml b/molecule/elasticstack_default/converge.yml index 1d69a093..bf23098f 100644 --- a/molecule/elasticstack_default/converge.yml +++ b/molecule/elasticstack_default/converge.yml @@ -31,6 +31,7 @@ ansible.builtin.apt: update_cache: yes cache_valid_time: 600 + changed_when: false when: ansible_os_family == 'Debian' - name: Install dependencies package: From 0300cc1b822a03750202a7c486397022985ba5cf Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Thu, 24 Aug 2023 10:37:34 +0200 Subject: [PATCH 8/9] Tuning parallel full stack tests down to one Maybe Runners run out of running ressources. --- .github/workflows/test_roles_pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_roles_pr.yml b/.github/workflows/test_roles_pr.yml index fdac2e43..84faf4a5 100644 --- a/.github/workflows/test_roles_pr.yml +++ b/.github/workflows/test_roles_pr.yml @@ -47,7 +47,7 @@ jobs: strategy: fail-fast: false - max-parallel: 4 + max-parallel: 1 matrix: distro: - ubuntu2204 From b7407e6f32e6c3e0e3119b9688141aa86c5abdfa Mon Sep 17 00:00:00 2001 From: Thomas Widhalm Date: Thu, 24 Aug 2023 15:51:21 +0200 Subject: [PATCH 9/9] Reverting last change - useless --- .github/workflows/test_roles_pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_roles_pr.yml b/.github/workflows/test_roles_pr.yml index 84faf4a5..fdac2e43 100644 --- a/.github/workflows/test_roles_pr.yml +++ b/.github/workflows/test_roles_pr.yml @@ -47,7 +47,7 @@ jobs: strategy: fail-fast: false - max-parallel: 1 + max-parallel: 4 matrix: distro: - ubuntu2204