Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntryPoint Parameters #2

Open
Rafacasari opened this issue Jan 31, 2025 · 7 comments · May be fixed by #3
Open

EntryPoint Parameters #2

Rafacasari opened this issue Jan 31, 2025 · 7 comments · May be fixed by #3
Assignees
Labels
bug Something isn't working

Comments

@Rafacasari
Copy link

I have been using BfevLibrary to make a C# version of asteriation's decompiler but seems there is no way to read EntryPoint parameters
(I think may be something ACNH specific? I remember someone trying to edit a file that had parameters in the entrypoint using Zelda EVFL editor and it was just crashing)

An example in Asteriation decompiler:
https://acnh.isomorphicbox.com/evfl/2.0.4/AI_NPC_Common.evfl
Image

Json generated by BfevLibrary:

Image

@ArchLeaders
Copy link
Member

This library is based on BotW and TotK, neither of which have parameters on the entry points.

Unfortunately, I don't have ACNH so, unless you know of another game that uses these, I will not be able to implement this.

@ArchLeaders ArchLeaders added bug Something isn't working wontfix This will not be worked on labels Jan 31, 2025
@Rafacasari
Copy link
Author

No idea if there is another game that uses it but seems I have found the implementation:
https://github.com/asteriation/acnh-eventflow-decompiler/blob/master/decompiler/bfevfl.py#L332

@ArchLeaders
Copy link
Member

ArchLeaders commented Jan 31, 2025

It doesn't look complicated, but without a file I won't be able to test it anyway.

@ArchLeaders
Copy link
Member

Seems I've just skipped reading those fields, so if I can get a test file it should be fairly simple to implement.

https://github.com/NCF-Library/BfevLibrary/blob/master/src/Core/EntryPoint.cs#L20-L22

@Rafacasari
Copy link
Author

Sorry for the delay, I haven't seen it before. Here is a test file if you want to test:
AI_NPC_Common.zip

@ArchLeaders
Copy link
Member

Thanks, I'll look into it when I have some free time.

@ArchLeaders ArchLeaders removed the wontfix This will not be worked on label Jan 31, 2025
@ArchLeaders ArchLeaders self-assigned this Jan 31, 2025
@Rafacasari
Copy link
Author

Just did some tests trying to implement and discovered that this file actually don't have any entrypoint with VariableDef (?)

Seems aster used the SubFlows to get parameters that are not defined in the entrypoint
https://github.com/asteriation/acnh-eventflow-decompiler/blob/95f33afe29572649d94b820128d54b5026e1b191/decompiler/cfg.py#L69

This one does have entrypoint parameters (in the slo_SellWeed entrypoint)
SNPC_slo_00_Peddling.zip

@Rafacasari Rafacasari linked a pull request Feb 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants