make user join/part messages optional

[andrewzah]

Hi, firstly thanks for the plugin.

Would it be possible to make user join/part messages optional, or put in a different discord channel?

[andrewzah]

Here is a sample diff for anyone interested in compiling a fork manually.

This code adds out-chat-channels and out-all-channels to the config. The former relays chat + /alert messages, and the former relays join/quit messages. It probably should be refined into options for each type of msg, but this works well enough for my purposes. HTH.

diff --git a/pom.xml b/pom.xml
index 0695d9f..e65e16c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -187,8 +187,8 @@
         <dependency>
             <groupId>uk.co.n3fs.mc</groupId>
             <artifactId>gchat-velocity</artifactId>
-            <version>2.0.2</version>
-            <scope>provided</scope>
+            <version>2.1.0</version>
+            <scope>compile</scope>
         </dependency>
         <dependency>
             <groupId>com.vdurmont</groupId>
diff --git a/src/main/java/uk/co/n3fs/mc/gcvbridge/GCVBConfig.java b/src/main/java/uk/co/n3fs/mc/gcvbridge/GCVBConfig.java
index 9d91138..e18a8ba 100644
--- a/src/main/java/uk/co/n3fs/mc/gcvbridge/GCVBConfig.java
+++ b/src/main/java/uk/co/n3fs/mc/gcvbridge/GCVBConfig.java
@@ -17,7 +17,8 @@ public class GCVBConfig {
 
     private final String token;
     private final List<Long> inChannels;
-    private final List<Long> outChannels;
+    private final List<Long> outChatChannels;
+    private final List<Long> outAllChannels;
     private final boolean playerlistEnabled;
     private final String playerlistFormat;
     private final String playerlistSeparator;
@@ -37,7 +38,8 @@ public class GCVBConfig {
 
         token = root.getNode("discord", "token").getString();
         inChannels = root.getNode("discord", "in-channels").getList(TypeToken.of(Long.class));
-        outChannels = root.getNode("discord", "out-channels").getList(TypeToken.of(Long.class));
+        outChatChannels = root.getNode("discord", "out-chat-channels").getList(TypeToken.of(Long.class));
+        outAllChannels = root.getNode("discord", "out-all-channels").getList(TypeToken.of(Long.class));
 
         playerlistEnabled = root.getNode("discord", "playerlist", "enabled").getBoolean(true);
         playerlistFormat = root.getNode("discord", "playerlist", "format").getString("**{count} players online:** ```\n{players}\n```");
@@ -76,8 +78,16 @@ public class GCVBConfig {
             .collect(Collectors.toList());
     }
 
-    public List<TextChannel> getOutChannels(DiscordApi dApi) {
-        return outChannels.stream()
+    public List<TextChannel> getOutChatChannels(DiscordApi dApi) {
+        return outChatChannels.stream()
+                .map(dApi::getTextChannelById)
+                .filter(Optional::isPresent)
+                .map(Optional::get)
+                .collect(Collectors.toList());
+    }
+
+    public List<TextChannel> getOutAllChannels(DiscordApi dApi) {
+        return outAllChannels.stream()
             .map(dApi::getTextChannelById)
             .filter(Optional::isPresent)
             .map(Optional::get)
diff --git a/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/GChatListener.java b/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/GChatListener.java
index 9c4a811..15000b7 100644
--- a/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/GChatListener.java
+++ b/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/GChatListener.java
@@ -6,20 +6,16 @@ import uk.co.n3fs.mc.gcvbridge.GCVBridge;
 import uk.co.n3fs.mc.gcvbridge.util.TextUtil;
 
 public class GChatListener {
-
     private final GCVBridge plugin;
-
     public GChatListener(GCVBridge plugin) {
         this.plugin = plugin;
     }
 
     @Subscribe
     public void onGChatMessage(GChatMessageFormedEvent event) {
-        if (plugin.getConfig().isRequireSendPerm() && !event.getSender().hasPermission("gcvb.send")) return;
         final String msg = TextUtil.stripString(TextUtil.toMarkdown(event.getMessage()));
 
-        plugin.getConfig().getOutChannels(plugin.getDApi())
+        plugin.getConfig().getOutChatChannels(plugin.getDApi())
                 .forEach(textChannel -> textChannel.sendMessage(msg));
     }
-
 }
diff --git a/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/NeutronListener.java b/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/NeutronListener.java
index 0628f94..e48a0ec 100644
--- a/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/NeutronListener.java
+++ b/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/NeutronListener.java
@@ -22,7 +22,7 @@ public class NeutronListener {
                 .replace("{author}", event.getAuthor().map(User::getName).orElse("CONSOLE"));
 
         if (!message.isEmpty()) {
-            plugin.getConfig().getOutChannels(plugin.getDApi())
+            plugin.getConfig().getOutChatChannels(plugin.getDApi())
                     .forEach(channel -> channel.sendMessage(message));
         }
     }
diff --git a/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/VelocityListener.java b/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/VelocityListener.java
index 402eb40..742f1ee 100644
--- a/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/VelocityListener.java
+++ b/src/main/java/uk/co/n3fs/mc/gcvbridge/velocity/VelocityListener.java
@@ -20,7 +20,7 @@ public class VelocityListener {
         String message = plugin.getConfig().getJoinFormat()
             .replace("{player}", event.getPlayer().getUsername());
 
-        plugin.getConfig().getOutChannels(plugin.getDApi()).forEach(chan -> chan.sendMessage(message));
+        plugin.getConfig().getOutAllChannels(plugin.getDApi()).forEach(chan -> chan.sendMessage(message));
     }
 
     @Subscribe
@@ -30,7 +30,7 @@ public class VelocityListener {
         String message = plugin.getConfig().getQuitFormat()
             .replace("{player}", event.getPlayer().getUsername());
 
-        plugin.getConfig().getOutChannels(plugin.getDApi()).forEach(chan -> chan.sendMessage(message));
+        plugin.getConfig().getOutAllChannels(plugin.getDApi()).forEach(chan -> chan.sendMessage(message));
     }
 
 }
diff --git a/src/main/resources/config.yml b/src/main/resources/config.yml
index 2fc8028..5754a91 100644
--- a/src/main/resources/config.yml
+++ b/src/main/resources/config.yml
@@ -10,7 +10,11 @@ discord:
   in-channels: []
   # The IDs of the channels to send messages to.
   # You can specify multiple channels here by separating the IDs with a comma.
-  out-channels: []
+  # For chat and /alert messages.
+  out-chat-channels: []
+  # For join/quit messages.
+  out-all-channels: []
+
   # Settings for the playerlist command
   playerlist:
     # Whether to enable the playerlist command.