-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Summary
The recent @mysten/messaging 0.4.0 migration to latest Sui/Seal still has merge-risk in two places:
- Runtime mismatch in CI/publish workflows:
- workflows run on Node 20
@mysten/sui@2.4.0requires Node>=22
- Script API typing drift:
scripts/utils.tsstill referenced older client typing/method style- this caused TS compile failures in scripts package
Impact
- CI can pass/fail unpredictably depending on runtime assumptions.
- Publish jobs may break once dependency constraints are enforced.
- Local helper scripts are incompatible with the current Sui client typing/API surface.
Proposed Fix
- Update GitHub workflows to Node 22.
- Add integration coverage in CI for localnet path.
- Keep publish gate strict by running unit tests pre-publish.
- Align
scripts/utils.tswith current@mysten/suiclient API/typing. - Declare
node >=22inpackages/messagingengines to match dependency requirements.
Validation
pnpm -C packages/messaging buildpnpm -C packages/messaging lintpnpm -C packages/messaging test:unitpnpm -C scripts exec tsc -p tsconfig.json --noEmit
(Integration tests require Docker/testcontainers runtime in CI or a Docker-enabled local environment.)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels