Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result refactor/#137 #145

Merged
merged 25 commits into from
Sep 14, 2024
Merged

Result refactor/#137 #145

merged 25 commits into from
Sep 14, 2024

Conversation

yougyung
Copy link
Member

πŸ“Œ μž‘μ—… λ‚΄μš©

2024-09-11.11.18.21.mov

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • κΈ°μ‘΄ μ„œλΉ„μŠ€μ—μ„œ favicon이 λΈŒλΌμš°μ €λ§ˆλ‹€ λ‹€λ₯΄κ²Œ μž‘λ™ν•˜λŠ” μ΄μŠˆκ°€ μžˆμ—ˆμŠ΅λ‹ˆλ‹€. favicon.ico파일이 μ œκ±°λ˜μ§€μ•Šμ•„ λ°œμƒλœ 문제둜 이전 PRμ—μ„œ μ œκ±°ν•œ 이후 배포 ν™˜κ²½μ—μ„œ λΈŒλΌμš°μ € 문제 없이 잘 μž‘λ™ν•˜λŠ” κ²ƒμœΌλ‘œ ν™•μΈλ˜μ—ˆμŠ΅λ‹ˆλ‹€.
  • init userμ—κ²Œ ν—ˆμš©λœ νŽ˜μ΄μ§€κ°€ grade-upload만 μ μš©λ˜μ–΄μ Έμžˆμ–΄, tutorial-pageλ₯Ό μΆ”κ°€ ν—ˆμš©ν–ˆμŠ΅λ‹ˆλ‹€.
  • κ²°κ³ΌνŽ˜μ΄μ§€μ˜ λͺ¨λ°”일기쀀 width 값이 넓은 것 κ°™μ•„ 이λ₯Ό μ€„μ΄λŠ” λ°©ν–₯으둜 λ°˜μ‘ν˜• μˆ˜μ •μ„ μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.
  • νŠœν† λ¦¬μ–Ό νŽ˜μ΄μ§€μ˜ λ¦¬λ””μžμΈμ„ μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.
  • 볡전, 전과생을 ν™•μž₯함에 λ”°λ₯Έ μ•ˆλ‚΄λ¬Έ 문ꡬ μˆ˜μ •μ„ μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.
  • κ²°κ³ΌνŽ˜μ΄μ§€μ—μ„œ μ‘Έμ—… κ°€λŠ₯ 여뢀에 λ”°λ₯Έ 상황별 λ©”μ‹œμ§€ λ…ΈμΆœ 둜직이 μ—†λŠ” λ¬Έμ œκ°€ μžˆμ–΄, μΆ”κ°€μ μœΌλ‘œ κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.
  • NavigationItem μ»΄ν¬λ„ŒνŠΈμ— target속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ€” κ³ λ―Ό ν–ˆλ˜ λΆ€λΆ„

  • νŠœν† λ¦¬μ–Ό νŽ˜μ΄μ§€μ—μ„œ μ£Όμš” κΈ°λŠ₯을 [λ‹¨μˆœ text] -> [μ‹€μ œν™”λ©΄]을 λ…ΈμΆœν•˜λ©΄, κΈ°λŠ₯ μ†Œκ°œ 및 μ‚¬μš©λ²•μ„ ν•¨κ»˜ μ œμ‹œν•  수 μžˆμ„ κ²ƒμ΄λΌλŠ” 생각이 λ“€μ—ˆμŠ΅λ‹ˆλ‹€. 이λ₯Ό μœ„ν•΄ κΈ°μ‘΄ λ””μžμΈ μ‹œμ•ˆμ—μ„œ gif이미지λ₯Ό λ„£λŠ” λ°©μ‹μœΌλ‘œ λ””μžμΈμ„ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€. λ””μžμΈ μˆ˜μ • μ œμ•ˆ μ£Όμ‹œλ©΄ λ°˜μ˜ν•˜κ² μŠ΅λ‹ˆλ‹€!

gahyuun
gahyuun reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@gahyuun gahyuun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€! νŠœν† λ¦¬μ–Ό λ””μžμΈ λ„ˆλ¬΄ μ˜ˆμ˜λ„€μ—¬!!

middleware.ts Outdated
@@ -45,7 +46,7 @@ export async function middleware(request: NextRequest) {
return await retryAuth(request);
}

if (auth.role === 'init' && !request.nextUrl.pathname.startsWith('/grade-upload')) {
if (auth.role === 'init' && !allowInitUserPath.some((path) => request.nextUrl.pathname.startsWith(path))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메인 νŽ˜μ΄μ§€λ„ μΆ”κ°€ν•΄μ£Όμ‹œλ©΄ κ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹€!

app/ui/user/user-info-card/user-info-message.tsx Outdated

const graduate_message = {
GRADUATED: '쑸업을 μΆ•ν•˜ν•©λ‹ˆλ‹€ !',
CANDIDATE: 'λͺ¨λ“  μ˜μ—­μ˜ 기쀀학점을 λ‹¬μ„±ν•΄μ£Όμ„Έμš”.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CANDIDATEλŠ” λ‹¨μˆœνžˆ μ΄μˆ˜ν•™μ μ΄ 0학점인 κ²½μš°λŠ” μ•„λ‹Œ 것 같은데 μ–΄λ–€ κ²½μš°μΈκ°€μš”?

app/ui/user/user-info-card/user-info-message.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image λ³΅μˆ˜μ „κ³΅μ—μ„  전곡 선택을 λ‹€ μ±„μšΈ ν•„μš”κ°€ μ—†λ‚˜μš”?

app/ui/user/user-info-card/user-info-message.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•΄λ‹Ή 브랜치 κΈ°μ€€, λΉŒλ“œ ν›„ μ‹€ν–‰ν•œ λ’€ μ–Έλ‹ˆ κ³„μ •μœΌλ‘œ λ‘œκ·ΈμΈν•˜κ΅¬ κ³Όλͺ© μΆ”κ°€λ‘œ 남은 학점을 채웠을 λ•Œ μ‘Έμ—… μ™„λ£ŒμΈλ° "λͺ¨λ“  μ˜μ—­μ˜ κΈ°μ€€ 학점을 λ‹¬μ„±ν•΄μ£Όμ„Έμš”" λΌλŠ” 메세지가 ν‘œμ‹œλ˜λ„€μš”!
image

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-wsluwurzlz.chromatic.com/

@yougyung
Copy link
Member Author

yougyung commented Sep 11, 2024 •
edited
Loading

CANDIDATEλŠ” λ‹¨μˆœνžˆ μ΄μˆ˜ν•™μ μ΄ 0학점인 κ²½μš°λŠ” μ•„λ‹Œ 것 같은데 μ–΄λ–€ κ²½μš°μΈκ°€μš”?

ν•΄λ‹Ή 브랜치 κΈ°μ€€, λΉŒλ“œ ν›„ μ‹€ν–‰ν•œ λ’€ μ–Έλ‹ˆ κ³„μ •μœΌλ‘œ λ‘œκ·ΈμΈν•˜κ΅¬ κ³Όλͺ© μΆ”κ°€λ‘œ 남은 학점을 채웠을 λ•Œ μ‘Έμ—… μ™„λ£ŒμΈλ° "λͺ¨λ“  μ˜μ—­μ˜ κΈ°μ€€ 학점을 λ‹¬μ„±ν•΄μ£Όμ„Έμš”" λΌλŠ” 메세지가 ν‘œμ‹œλ˜λ„€μš”!

λ³΅μˆ˜μ „κ³΅μ—μ„  전곡 선택을 λ‹€ μ±„μšΈ ν•„μš”κ°€ μ—†λ‚˜μš”?

λ³΅μˆ˜μ „κ³΅μ—μ„œλ„ ν‘œμ‹œλœ κΈ°μ€€ 학점은 λͺ¨λ‘ μ΄μˆ˜ν•΄μ•Όν•©λ‹ˆλ‹€!
λ”°λΌμ„œ, μ‘Έμ—…ν•„μš”ν•™μ μ„ λͺ¨λ‘ μ±„μ› μŒμ—λ„ λΆˆκ΅¬ν•˜κ³  λͺ¨λ“  μΉ΄ν…Œκ³ λ¦¬λ₯Ό λ§Œμ‘±ν•˜μ§€μ•Šμ•„ 쑸업이 λΆˆκ°€ν•œ κ²½μš°μ— λͺ¨λ“  μ˜μ—­μ˜ κΈ°μ€€ 학점을 λ‹¬μ„±ν•΄μ£Όμ„Έμš”ν•΄λ‹Ή λ©”μ‹œμ§€λ₯Ό λ…ΈμΆœν–ˆλ˜ κ²ƒμΈλ°μš”. 이런 μ‘Έμ—… ν›„λ³΄μžλ₯Ό CANDIDATE둜 ν‘œν˜„ν–ˆμ—ˆμ–΄μš”.

근데 κ°€ν˜„μ΄μ˜ μ˜κ²¬μ„ λ“£κ³  2604545 λ‘œμ§μ„ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
"μ‘Έμ—…ν•„μš”ν•™μ λ³΄λ‹€ ~학점이 λΆ€μ‘±ν•΄μš”" λΌλŠ” κΈ°μ‘΄ text μ€‘μ‹¬μœΌλ‘œ μˆ˜μ •μ„ μ§„ν–‰ν•˜λ‹€ λ³΄λ‹ˆ κ°œλ°œλ‹Ήμ‹œ κ³ λ €ν•˜μ§€ λͺ»ν–ˆλ˜ λΆ€λΆ„μ΄μ—ˆλŠ”λ°,
[μ‘Έμ—…ν•„μš”ν•™μ κΉŒμ§€ 남은학점]기쀀이 μ•„λ‹Œ [쑸업을 μœ„ν•œ μž”μ—¬ν•™μ ]이 기쀀이 λ˜λ„λ‘ λ‘œμ§μ„ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€. μœ„ κ³Όμ •μ—μ„œ CANDIDATE와 같은 type은 μ‚­μ œ λ˜μ—ˆμ–΄μš”!
의견 κ°μ‚¬ν•©λ‹ˆλ‹€! @gahyuun

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-ucvnczimsp.chromatic.com/

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-ykplucxibb.chromatic.com/

seonghunYang
seonghunYang previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@seonghunYang seonghunYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • κ°€ν˜„μ˜ 리뷰 사항을 μ œμ™Έν•˜κ³  μ½”λ“œλ§Œ λ³Ό λ•Œ, μ˜λ„κ°€ λͺ…ν™•νžˆ λ“œλŸ¬λ‚˜κ³  가독성이 μ’‹λ‹€κ³  λŠκΌˆμŠ΅λ‹ˆλ‹€. μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€.

  • κ°œμ„ ν•΄μ£Όμ‹  νŠœν† λ¦¬μ–Όμ€ 정말 μ’‹λ„€μš”. μ˜¬λ €μ£Όμ‹  μ˜μƒμ„ κ·ΈλŒ€λ‘œ README에 νŠœν† λ¦¬μ–Όλ‘œ 좔가해도 쒋을 것 κ°™μ•„μš”.

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-zikvxdubtu.chromatic.com/

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-oglzwafwxo.chromatic.com/

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-smskrypezd.chromatic.com/

seonghunYang
seonghunYang previously approved these changes Sep 12, 2024
View reviewed changes
@gahyuun
Copy link
Member

gahyuun commented Sep 13, 2024 •
edited
Loading

  1. μ‘Έμ—…κΉŒμ§€ 63.5학점이 λ‚¨μ•˜λŠ”λ° μ™œ 쑸업학점이 134학점이고 μ΄μˆ˜ν•™μ μ΄ 131ν•™μ μ΄λ„€μš”! λ³΅μˆ˜μ „κ³΅ λ•Œλ¬Έμ— 그런 것 같은데 μ‚¬μš©μž μž…μž₯μ—μ„œλŠ” 쑰금 ν—·κ°ˆλ¦΄ μˆ˜λ„ μžˆμ–΄μ„œ ν…μŠ€νŠΈ κ°™μ€κ²Œ ν¬ν•¨λ˜λ©΄ 더 쒋지 μ•Šμ„κΉŒμš”?
image

  1. μΊμ‹œ λ•Œλ¬ΈμΈ 것 같은데 전곡 선택 κ³Όλͺ© 확인을 ν΄λ¦­ν–ˆμ„ λ•Œ, ꡐ양 κ³Όλͺ©μ΄ λœ¨λ„€μš© ( 개발λͺ¨λ“œμΌλ•Œλ§Œ λ°œμƒν•©λ‹ˆλ‹€ )
    https://github.com/user-attachments/assets/bed46369-c9aa-4c7c-90f6-e7e93e9ab671

  2. μ–Έλ‹ˆκ»„λ‘œ 둜그인 ν•˜κ΅¬ λ‘œκ·Έμ•„μ›ƒ ν›„ 제 κ³„μ •μœΌλ‘œ λ‘œκ·ΈμΈν–ˆλŠ”λ°, μ–Έλ‹ˆ μ‘Έμ—… κ²°κ³Όκ°€ λœ¨λ„€μš”γ… γ… ! ( 개발λͺ¨λ“œμΌλ•Œλ§Œ λ°œμƒν•©λ‹ˆλ‹€ )
    https://github.com/user-attachments/assets/0711769e-fe8e-45eb-8bde-30158d5f2253

  3. 제 κ³„μ •μœΌλ‘œ μ‘Έμ—… 학점을 계산해보면 전곡 25학점, μΌλ°˜κ΅μ–‘ 4학점 λ‚¨μ•„μ„œ μž”μ—¬ν•™μ μ΄ 총 29학점인건데 24학점이 λ‚¨μ•˜λ‹€κ³  λœ¨λ„€μš”..! μ•„λ§ˆ 전곡 μ„ νƒμ—μ„œ 이수 학점이 κΈ°μ€€ 학점보닀 5학점 λ§Žμ•„μ„œ 그런 것 κ°™λ„€μš”
    https://github.com/user-attachments/assets/ed33505c-bfd4-4cd4-a50f-1b206a10751f

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-bazdrddizl.chromatic.com/

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-lqfjcrbvda.chromatic.com/

@yougyung
Copy link
Member Author

yougyung commented Sep 13, 2024 •
edited
Loading

κ΅¬λ‘λ‘œ μ„€λͺ…λ“œλ¦¬μ§€ μ•Šμ€ 4번의 경우 μž”μ—¬ν•™μ μ„ κ³„μ‚°ν•˜λŠ” λ‘œμ§μ„ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. 였λ₯˜ λ°œκ²¬ν•΄μ£Όμ…”μ„œ κ°μ‚¬ν•΄μš© e8e5023

λ”λΆˆμ–΄ 말씀해주신 1λ²ˆμ— λŒ€ν•΄μ„œλŠ” μ•„λž˜ ν…μŠ€νŠΈ 변경을 톡해 μ˜€ν•΄λ₯Ό 쀄일 수 μžˆκ² λ‹€λŠ” 생각이 λ“€μ–΄ 변경을 μ§„ν–‰ν–ˆμ–΄μš”. 5a0c9ca
μ‘Έμ—…ν•„μš”ν•™μ ->μ‘Έμ—…μ΅œμ†Œν•™μ 
총 이수 학점->ν˜„μž¬μ΄μˆ˜ν•™μ 

ν˜Ήμ€ λ‹€λ₯Έ λ°©λ²•μœΌλ‘œ μ‘Έμ—…ν•„μš”ν•™μ μ„ μ•„μ˜ˆ λ…ΈμΆœμ—μ„œ μ œκ±°ν•œλ‹€λ©΄ μ‚¬μš©μž ν˜Όλž€μ„ 없앨 수 μžˆμ„ 것 κ°™λ‹€λŠ” 생각도 λ“€μ–΄μš”. 쑸업사정결과λ₯Ό ν™•μΈν•˜λŠ”λ° λ°˜λ“œμ‹œ ν•„μš”ν•œ 정보가 μ•„λ‹ˆκΈ°λ„ν•˜κ³ μš”!

gahyuun
gahyuun approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@gahyuun gahyuun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€~
μ‘Έμ—… ν•„μš” 학점을 λ…ΈμΆœ μ œκ±°ν•˜λŠ” 것도 쒋은 방법일 수 μžˆκ² λ„€μš”!

@yougyung yougyung merged commit 1126c68 into main Sep 14, 2024
3 checks passed
@yougyung yougyung deleted the result-refactor/#137 branch September 14, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gahyuun gahyuun gahyuun approved these changes

@seonghunYang seonghunYang seonghunYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yougyung @gahyuun @seonghunYang