Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer issue #123

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Drawer issue #123

merged 3 commits into from
Jun 30, 2024

Conversation

yougyung
Copy link
Member

πŸ“Œ μž‘μ—… λ‚΄μš©

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • Drawer onReleaseμ—μ„œ κ°„ν—μ μœΌλ‘œ λ°œμƒν•˜λŠ” λ‹«νž˜ issue ν•΄κ²°

진행사항

  • κ°€ν˜„μ΄κ°€ μ œμ•ˆν•΄μ€€ μˆ˜μ •λ°©μ‹ ν† λŒ€λ‘œ 개발 μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.
    • Drawerλ‚΄λΆ€μ˜ onRelase -> onClose λ³€κ²½
      μš°λ €ν•΄μ£Όμ…¨λ˜ μƒν™©κ³ΌλŠ” 달리 μ €λŠ” ν•΄λ‹Ή 절차만 진행해도 μž‘λ™μ— 무리가 μ—†μ—ˆμœΌλ‚˜, toggle -> open으둜 λ³€κ²½ν•˜λŠ” 것이 μ˜λ―Έμƒ μ ν•©ν•˜λ‹€λŠ” 생각이 λ“€μ–΄ λ³€κ²½ μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.
    • Drawer trigger역할을 ν•˜λŠ” λ²„νŠΌ toggle -> open λ³€κ²½

@yougyung yougyung linked an issue Jun 17, 2024 that may be closed by this pull request
Drawer issue #122
Closed
@yougyung yougyung self-assigned this Jun 17, 2024
@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-jsnjqdrwjn.chromatic.com/

@yougyung yougyung changed the title fix: change Drawer onRelease to onClose Drawer issue Jun 18, 2024
seonghunYang
seonghunYang approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@seonghunYang seonghunYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 수고 λ§Žμ•˜μ–΄μš”

gahyuun
gahyuun approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@gahyuun gahyuun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

@yougyung yougyung merged commit c2ac546 into main Jun 30, 2024
2 of 3 checks passed
@yougyung yougyung deleted the drawer-issue/#122 branch June 30, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gahyuun gahyuun gahyuun approved these changes

@seonghunYang seonghunYang seonghunYang approved these changes

Assignees

@yougyung yougyung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drawer issue
3 participants
@yougyung @seonghunYang @gahyuun