Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatcherState.LinkCache confusion #503

Open
Noggog opened this issue Dec 4, 2024 · 0 comments
Open

PatcherState.LinkCache confusion #503

Noggog opened this issue Dec 4, 2024 · 0 comments

Comments

@Noggog
Copy link
Member

Noggog commented Dec 4, 2024

Should potentially expose LinkCacheOnlyEnabled vs LinkCacheFull, potentially, to help clarify exposure of whether to include only enabled mods in the lookups or not?

Right now it might be that Mo2 and other mod managers are trimming disabled mods, so they're effectively the same. But I could imagine it causes issues if:

  • Run against a plugins.txt with disabled mods
  • A disabled mod has the winning override

That situation will behave unexpectedly with the typical WinningOverride patterns?

Alternatively, we could have a setting called "Only Include Enabled Mods" saved per patcher setting, and synthesis could do the filtering out itself to not rely on the mod manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant