Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkCache.WinningOverride calls #558

Open
Noggog opened this issue Oct 12, 2024 · 0 comments
Open

LinkCache.WinningOverride calls #558

Noggog opened this issue Oct 12, 2024 · 0 comments

Comments

@Noggog
Copy link
Member

Noggog commented Oct 12, 2024

linkCache.PriorityOrder.WinningOverrides()
The .PriorityOrder style winning overrides has been the goto standard. But that's from the days of synthesis patchers, which typically loop over all the records once and do whatever

But for repeated calls, this redoes a lot of work, as it's just working off IEnumerable, it has to look for and construct the winning overrides each call. This means accessing the related group (which hits the disk) foreach mod, and then constructing the set to find which ones are the winning overrides. The disk hit especially isn't great

If the linkCache itself offered the call: linkCache.WinningOverrides() it could then fulfill it via the actual cache (rather than the IEnumerable member, which cannot)
Subsequent calls would then be a near instant fulfillment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant