Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragments to hits/digi with new calo decoders (replaces PR #1372 ) #1385

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

giro94
Copy link

@giro94 giro94 commented Dec 9, 2024

No description provided.

@giro94
Copy link
Author

giro94 commented Dec 9, 2024

Ok

@FNALbuild
Copy link
Collaborator

Hi @giro94,
You have proposed changes to files in these packages:

  • DAQ

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for c1f587d: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at c1f587d.

Test Result Details
test with Command did not list any other PRs to include
merge Merged c1f587d at 11e1039
build (prof) Log file. Build time: 04 min 16 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 🔶 TODO (1) FIXME (1) in 1 files
clang-tidy 🔶 3 errors 32 warnings
whitespace check 🔶 found whitespace errors

N.B. These results were obtained from a build of this Pull Request at c1f587d after being merged into the base branch at 11e1039.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@giro94 giro94 closed this Dec 9, 2024
@giro94 giro94 changed the title Giro94/calo dev Fragments to hits/digi with new calo decoders (replaces PR #1372 ) Dec 9, 2024
@giro94 giro94 reopened this Dec 9, 2024
@giro94
Copy link
Author

giro94 commented Dec 9, 2024

CaloRecoFromFragments prepared to accomodate the new CaloDecoder and be able to interpret all types of calo hits.

(replaces PR #1372 )

Copy link
Collaborator

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the algorithm but the code looks fine.

@brownd1978 brownd1978 requested a review from gianipez December 10, 2024 19:51
@brownd1978 brownd1978 self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants